Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#39465] - Fixed rate button misalignment

? ? Pending

User tests: Successful: Unsuccessful:

avatar JackKellyUK
JackKellyUK
21 Dec 2022

Pull Request for Issue #37920 .

Summary of Changes

Added vertical align baseline class to Rate button

Testing Instructions

  • Enable the vote plugin
  • Show voting (in an article or a menu item)

Actual result BEFORE applying this Pull Request

Rate button is misaligned

Expected result AFTER applying this Pull Request

Rate button is aligned as expected

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 21 Dec 2022
Category ⇒ Front End Plugins
avatar JackKellyUK JackKellyUK - open - 21 Dec 2022
avatar JackKellyUK JackKellyUK - change - 21 Dec 2022
Status New ⇒ Pending
avatar sandewt
sandewt - comment - 22 Dec 2022

Wouldn't it be nicer to solve this with css code?

.content_vote .btn {
  vertical-align: baseline;
}
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39465.
avatar sandewt sandewt - test_item - 30 Dec 2022 - Tested successfully
avatar sandewt
sandewt - comment - 30 Dec 2022

I have tested this item ✅ successfully on 5765a55

See my comment above

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39465.

avatar viocassel viocassel - test_item - 5 Jan 2023 - Tested successfully
avatar viocassel
viocassel - comment - 5 Jan 2023

I have tested this item ✅ successfully on 5765a55

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39465.

avatar Quy Quy - change - 5 Jan 2023
Status Pending ⇒ Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 5 Jan 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39465.

avatar fancyFranci fancyFranci - close - 7 Jan 2023
avatar fancyFranci fancyFranci - merge - 7 Jan 2023
avatar fancyFranci fancyFranci - change - 7 Jan 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-01-07 17:10:06
Closed_By ⇒ fancyFranci
Labels Added: ?
avatar fancyFranci
fancyFranci - comment - 7 Jan 2023

Thank you for this small but nice PR

Add a Comment

Login with GitHub to post a comment