Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#39453] - [4] Remove unused com_media field "upload_mime_illegal"

? Language Change Documentation Required PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar ReLater
ReLater
20 Dec 2022

All credits to @Kostelano . I only took over his closed pr #39196

Closes #38280

Summary of Changes

  • Remove field upload_mime_illegal from com_media settings.
  • Deprecate associated language strings.

Testing Instructions

  • Code review shoud be sufficient after several confirmations that this field is not used in core. See comments: #38280 and #39196
  • I you think it's worth it: Change/Add mime entries in com_media configuration in field Forbidden MIME Types.
    • Check if these settings have any influence on file uploads in the Media Manager. This should not be the case.

Actual result BEFORE applying this Pull Request

  • Settings ignored on file uploads in media manager.

Expected result AFTER applying this Pull Request

  • No change. Settings ignored on file uploads in media manager.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 20 Dec 2022
Category ⇒ Administration com_media
avatar ReLater ReLater - open - 20 Dec 2022
avatar ReLater ReLater - change - 20 Dec 2022
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Dec 2022
Category Administration com_media ⇒ Administration com_media Language & Strings
avatar ReLater ReLater - change - 20 Dec 2022
Labels Added: PR-4.3-dev
avatar ReLater ReLater - change - 20 Dec 2022
The description was changed
avatar ReLater ReLater - edited - 20 Dec 2022
avatar ReLater ReLater - change - 20 Dec 2022
Title
…
WIP!! config.xml. Remove field upload_mime_illegal
[4] Remove unused com_media field "upload_mime_illegal"
avatar ReLater ReLater - edited - 20 Dec 2022
avatar ReLater ReLater - change - 20 Dec 2022
The description was changed
avatar ReLater ReLater - edited - 20 Dec 2022
avatar ReLater ReLater - change - 20 Dec 2022
The description was changed
avatar ReLater ReLater - edited - 20 Dec 2022
avatar ChristineWk ChristineWk - test_item - 20 Dec 2022 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 20 Dec 2022

I have tested this item ✅ successfully on ee05408

J 4.2.7-dev

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39453.

avatar viocassel viocassel - test_item - 20 Dec 2022 - Tested successfully
avatar viocassel
viocassel - comment - 20 Dec 2022

I have tested this item ✅ successfully on ee05408

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39453.

avatar richard67 richard67 - change - 21 Dec 2022
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 21 Dec 2022

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39453.

avatar obuisard obuisard - change - 28 Dec 2022
The description was changed
avatar obuisard obuisard - edited - 28 Dec 2022
avatar obuisard obuisard - change - 28 Dec 2022
The description was changed
avatar obuisard obuisard - edited - 28 Dec 2022
avatar ReLater
ReLater - comment - 29 Dec 2022

I don't know what

Documentation link for docs.joomla.org

means. I have adapted https://docs.joomla.org/Help4.x:Media:_Options , but ????

avatar carlitorweb
carlitorweb - comment - 12 Jan 2023

Documentation changed ✔️ (https://docs.joomla.org/Help4.x:Media:_Options)

avatar obuisard obuisard - change - 12 Jan 2023
Labels Added: ? Language Change Documentation Required
avatar obuisard obuisard - change - 12 Jan 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-01-12 02:53:28
Closed_By ⇒ obuisard
avatar obuisard obuisard - close - 12 Jan 2023
avatar obuisard obuisard - merge - 12 Jan 2023
avatar obuisard
obuisard - comment - 12 Jan 2023

Thank you @ReLater for the PR!

Add a Comment

Login with GitHub to post a comment