? ? Pending

User tests: Successful: Unsuccessful:

avatar janschoenherr
janschoenherr
16 Dec 2022

This PR fixes the default value for the $language parameter. It makes it equal to Joomla\CMS\Helper\RouteHelper found in libraries/src/Helper/RouteHelper.php.

I am not sure if this is documented somewhere and that documentation would need to be updated.

avatar joomla-cms-bot joomla-cms-bot - change - 16 Dec 2022
Category Front End com_content
avatar janschoenherr janschoenherr - open - 16 Dec 2022
avatar janschoenherr janschoenherr - change - 16 Dec 2022
Status New Pending
avatar chmst
chmst - comment - 16 Dec 2022

looks good to me but do you have a test instruction? Had you an error message or warning here?

avatar janschoenherr
janschoenherr - comment - 19 Dec 2022

There is no error, it is just phpstan reporting this.

avatar ceford ceford - test_item - 19 Dec 2022 - Tested successfully
avatar ceford
ceford - comment - 19 Dec 2022

I have tested this item successfully on 73a9741

Looked at the code and tested the patch. I doubt this would ever show up as a problem. No documentation change required.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39434.

avatar Quy Quy - test_item - 19 Dec 2022 - Tested successfully
avatar Quy
Quy - comment - 19 Dec 2022

I have tested this item successfully on 73a9741


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39434.

avatar Quy Quy - change - 19 Dec 2022
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 19 Dec 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39434.

avatar wilsonge wilsonge - close - 28 Dec 2022
avatar wilsonge wilsonge - merge - 28 Dec 2022
avatar wilsonge wilsonge - change - 28 Dec 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-12-28 12:18:30
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 28 Dec 2022

Thanks!

Add a Comment

Login with GitHub to post a comment