? ? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
15 Dec 2022

Summary of Changes

Randomly when I run my DPMedia system tests, a deprecated warning pops up in the action logs module in the back end dashboard. I couldn't identify which core extension is writing a null value as it happens with DPMedia which has no action logs plugin, so it must be a core extension.

Nevertheless this should be caught as it is very much possible to write null values into the action logs table.

Review should be enough.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 15 Dec 2022
Category Administration
avatar laoneo laoneo - open - 15 Dec 2022
avatar laoneo laoneo - change - 15 Dec 2022
Status New Pending
avatar laoneo laoneo - change - 15 Dec 2022
The description was changed
avatar laoneo laoneo - edited - 15 Dec 2022
avatar sandewt
sandewt - comment - 15 Dec 2022

I couldn't identify which core extension is writing a null value as it happens with DPMedia which has no action logs plugin, so it must be a core extension.

Maybe the following code will give you a little more information?

$value = trim($value);

if (empty($value))
{
	unset($messageData[$key]);
	continue;
}

$value = htmlspecialchars($value, ENT_QUOTES, 'UTF-8');

screen shot 2022-12-15 at 08 43 46


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39421.

avatar laoneo
laoneo - comment - 15 Dec 2022

@sandewt why should it? Where is this code located?

avatar sandewt
sandewt - comment - 15 Dec 2022

why should it?

Line 203: $value = $value ? htmlspecialchars($value, ENT_QUOTES, 'UTF-8') : '';

In case of $value = '', you will see less information, compared to the image above.

I don't know what exactly happens with DPMedia. I hope you can follow my reasoning.
issue_actionlog-2

Where is this code located?

Line 203 ...

avatar laoneo
laoneo - comment - 15 Dec 2022

It is not about the code change. All I wanted to say that it happens randomly during the tests which I can't pause and identify which extension is causing the issue.

abf9e13 15 Dec 2022 avatar laoneo null
avatar laoneo laoneo - change - 15 Dec 2022
Labels Added: ?
avatar sandewt
sandewt - comment - 15 Dec 2022

It is not about the code change. All I wanted to say that it happens randomly during the tests which I can't pause and identify which extension is causing the issue.

I understand, I wanted to offer you an alternative that provides just a little more information.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39421.

avatar joomdonation joomdonation - test_item - 29 Dec 2022 - Tested successfully
avatar joomdonation
joomdonation - comment - 29 Dec 2022

I have tested this item successfully on abf9e13

Code review !


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39421.

avatar sandewt sandewt - test_item - 30 Dec 2022 - Tested successfully
avatar sandewt
sandewt - comment - 30 Dec 2022

I have tested this item successfully on abf9e13

Code viewed


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39421.

avatar richard67 richard67 - change - 30 Dec 2022
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 30 Dec 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39421.

avatar laoneo laoneo - change - 30 Dec 2022
Labels Added: ?
avatar roland-d roland-d - change - 2 Jan 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-01-02 10:36:07
Closed_By roland-d
avatar roland-d roland-d - close - 2 Jan 2023
avatar roland-d roland-d - merge - 2 Jan 2023
avatar roland-d
roland-d - comment - 2 Jan 2023

Thank you

Add a Comment

Login with GitHub to post a comment