[#39401] - [4.3] Update deleted files list in script.php for upcoming 4.3.0-alpha2
- Fixed in Code Base
- 17 Dec 2022
- Medium
- Build: 4.3-dev
- # 39401
- Diff
- richard67:4.3-dev-deleted-files-and-folders-2022-12-12
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
-
Update the section comments for deleted files and folders for 4.3 and to the current 4.3.0-alpha1.
-
Update deleted files to changes from following PRs:
- #38466 - file
/plugins/content/emailcloak/emailcloak.php - #38470 - file
/plugins/content/fields/fields.php
- Remove js files from PR #38823 from the deleted files list because we have to keep them for b/c of layout overrides.
For the same reason, the deleted js files from PR #39374 are not added to the list with change 2. above.
The broken build will be fixed with another PR, see discussion in my PR's #39408 and #39413 .
Testing Instructions
Code review.
Or if you want to make a real test, update a 4.3.0-alpha1 or any older 4.x version to the last 4.3 nightly build to get the actual result, and update a 4.3.0-alpha1 or any older 4.x version to the update package built by Drone for this PR to get the expected result.
Actual result BEFORE applying this Pull Request
Files and folders mentioned at item 2 of the description above are still present after updating from a 4.3.0-alpha1 or any older 4.x version.
Expected result AFTER applying this Pull Request
All files and folders mentioned at item 2 of the description above have been deleted after updating from a 4.3.0-alpha1 or any older 4.x version.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_admin |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-4.3-dev
|
||
| Title |
|
||||||
We have discussed in the CMS Maintainers team. I will modify this PR here on Friday because I don't have the time today and tomorrow. As it looks now (still collecting opinions), the JS files will be removed from the list of files to be deleted on update.
| Labels |
Added:
?
?
|
||
| Labels |
Removed:
?
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-12-17 15:20:45 |
| Closed_By | ⇒ | obuisard |
Thank you, Richard @richard67, as always.
Due to a discussion in my other PR #39413 I'd like to have a decision if I shall remove the following lines from this PR https://github.com/joomla/joomla-cms/pull/39401/files#diff-db7eb77540ff419bd7e6557d2779f4cf1e31158c20cb4b63dbbe8d6c426385adR6486-R6491 , therefore I set the RLDQ label.