? Success

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
22 Jul 2014

Currently, com_ajax is hardcoded to load the "Ajax" plugin group.
This PR proposes to add support for a group URL parameter which tells com_ajax to import a custom plugin group. If omitted it will fall back to the ajax group.

The reason is that we may have for example a content plugin which uses Ajax functionality. With the current implementation it would neeed two plugins, one in the content group for the markup/whatever and a second one in the ajax group to process the AJAX requests. That doesn't make much sense.

Testing

  • You can use the example plugin https://github.com/Joomla-Ajax-Interface/Ajax-Latest-Articles to see that nothing breaks when using index.php?option=com_ajax&plugin=latestarticles&format=debug (should give you a list of articles).
  • To test the new group parameter you can add &group=content to the URL and see that the example plugin isn't triggered anymore (you get an empty array).
  • Now you can copy the function onAjaxLatestarticles from the example plugin to a content plugin of your choice and it should work again.
avatar Bakual Bakual - open - 22 Jul 2014
avatar betweenbrain
betweenbrain - comment - 22 Jul 2014

Tested and works great for me.

I also whipped up a content plugin group version of the Ajax Latest Articles plugin, availabe at https://github.com/Joomla-Ajax-Interface/Ajax-Latest-Articles/tree/content

avatar Kubik-Rubik
Kubik-Rubik - comment - 22 Jul 2014

@test

Tested it successfully!

avatar betweenbrain
betweenbrain - comment - 22 Jul 2014

Marking as RTC then.

avatar infograf768
infograf768 - comment - 22 Jul 2014

@Bakual
Do we need a new Feature tracker ?

avatar Bakual
Bakual - comment - 22 Jul 2014

I'm fine without a tracker :smile:

avatar betweenbrain
betweenbrain - comment - 23 Jul 2014

Feature tracker at http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33982

@Kubik-Rubik can you report your successful test on the tracker as well so we can get this merged? Thanks!

avatar Kubik-Rubik
Kubik-Rubik - comment - 23 Jul 2014

@betweenbrain Done! :-)

avatar betweenbrain
betweenbrain - comment - 23 Jul 2014

Thanks @Kubik-Rubik! Good to merge in my opinion.

avatar Bakual Bakual - reference | 1829e8a - 23 Jul 14
avatar Bakual
Bakual - comment - 23 Jul 2014

Merged into 3.4-dev. Thanks all.

avatar Bakual Bakual - close - 23 Jul 2014
avatar Bakual Bakual - change - 23 Jul 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-07-23 19:17:09
avatar Bakual Bakual - close - 23 Jul 2014
avatar Bakual Bakual - head_ref_deleted - 23 Jul 2014
avatar nielsnuebel
nielsnuebel - comment - 21 Sep 2016

@Bakual i tried this with the group editors-xtd. Does not worked. Maybe i misunderstood these workflow

avatar Bakual
Bakual - comment - 21 Sep 2016

It should work with that group as well. You just need to pass the plugin group in the AJAX request (&group=editors-xtd).

avatar mbabker
mbabker - comment - 21 Sep 2016

As long as the default CMD filter isn't stripping the -. If it's not
working that's probably the issue.

On Wednesday, September 21, 2016, Thomas Hunziker notifications@github.com
wrote:

It should work with that group as well. You just need to pass the plugin
group in the AJAX request (&group=editors-xtd).


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#3938 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfodxrNDa6pZKuCjzW0kbNHSt8E9vRks5qsT8ggaJpZM4CPdHz
.

avatar nielsnuebel
nielsnuebel - comment - 21 Sep 2016

No it dosen't.

This is my link index.php?option=com_ajax&plugin=GetForm&format=raw&group=editors-xtd

The Dispatcher has only System Plugins
https://www.dropbox.com/s/vo2ffqmgyhivglx/Screenshot%202016-09-21%2016.34.08.jpg?dl=0

avatar Bakual
Bakual - comment - 21 Sep 2016

To me it looks then like JPluginHelper::importPlugin() doesn't work with that plugin group or at least doesn't register them in that observer array for some reason. I would have to track down how the editor buttons plugins are called in detail.

avatar zero-24
zero-24 - comment - 21 Sep 2016

Maybe it would be better to open a new issue than ;)

Add a Comment

Login with GitHub to post a comment