User tests: Successful: Unsuccessful:
Pull Request for Issue #29565.
Some of our List base custom fields like SQL uses OptionsRule https://github.com/joomla/joomla-cms/blob/4.2-dev/libraries/src/Form/Rule/OptionsRule.php to validate it's data. This rule requires a valid $form object to validate data in case the options for the field not defined in XML but dynamic defined (for example, from database) via getOptions method of the field type
This PR changes logic of checkDefaultValue method in FieldModel class to handle default value properly for these kind of custom fields. It is a bug fix, but I decided to implement the change to 4.3 branch so that we have more time for reviewing and testing the change. I also includes the change from PR #39354 (for 4.2 branch) so to avoid merge conflict.
Ping @laoneo for checking this change.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Category | ⇒ | Administration com_fields |
| Status | New | ⇒ | Pending |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-02-24 04:49:28 |
| Closed_By | ⇒ | joomdonation | |
| Labels |
Added:
bug
Small
PR-4.4-dev
|
||
This pull request has been automatically rebased to 4.4-dev.