bug Small PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
4 Dec 2022

Pull Request for Issue #29565.

Summary of Changes

Some of our List base custom fields like SQL uses OptionsRule https://github.com/joomla/joomla-cms/blob/4.2-dev/libraries/src/Form/Rule/OptionsRule.php to validate it's data. This rule requires a valid $form object to validate data in case the options for the field not defined in XML but dynamic defined (for example, from database) via getOptions method of the field type

This PR changes logic of checkDefaultValue method in FieldModel class to handle default value properly for these kind of custom fields. It is a bug fix, but I decided to implement the change to 4.3 branch so that we have more time for reviewing and testing the change. I also includes the change from PR #39354 (for 4.2 branch) so to avoid merge conflict.

Ping @laoneo for checking this change.

Testing Instructions

  1. Use Joomla 4.3
  2. Follow instructions at #29565 , confirm the issue
  3. Apply patch, confirm the issue fixed.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 4 Dec 2022
Category Administration com_fields
avatar joomdonation joomdonation - open - 4 Dec 2022
avatar joomdonation joomdonation - change - 4 Dec 2022
Status New Pending
avatar HLeithner
HLeithner - comment - 30 Sep 2023

This pull request has been automatically rebased to 4.4-dev.

avatar joomdonation joomdonation - change - 24 Feb 2024
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2024-02-24 04:49:28
Closed_By joomdonation
Labels Added: bug Small PR-4.4-dev
avatar joomdonation joomdonation - close - 24 Feb 2024

Add a Comment

Login with GitHub to post a comment