[#39348] - [4.2] Fix library autoloading
- Fixed in Code Base
- 14 Jan 2023
- Medium
- Build: 4.2-dev
- # 39348
- Diff
- SharkyKZ:j4/fix/library-autoload
User tests: Successful: Unsuccessful:
Summary of Changes
Fixes #39347.
This fixes some issues in namespace mapper regarding library extension autoloading. First, this changes the manifest lookup from JPATH_LIBRARIES to JPATH_MANIFESTS directory where library manifests are actually stored. Secondly, this adds support for the possibly undocumented "vendor" library structure.
Testing Instructions
Documentation Changes Required
Although this PR is a bug fix, library autoloading and "vendor" library structure features are probably not documented. So documentation should be added somewhere.
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
@sergeytolkachyov Could you please go to https://issues.joomla.org/tracker/joomla-cms/39348 , click on Test this button and report your test result there so that your test will be counted? We require two successful tests for each PR before it can be merged.
I have tested this item
Tested this successfully.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39348.
Thanks @sergeytolkachyov
I've restored @sergeytolkachyov 's test result because the commits which have invalidated the test counter were just removing a redundant variable declaration and a clean branch update. The PR should still work the same as before.
But I think it is not easy to test without having an example library following that vendor structure.
I've restored @sergeytolkachyov 's test result because the commits which have invalidated the test counter were just removing a redundant variable declaration and a clean branch update. The PR should still work the same as before.
But I think it is not easy to test without having an example library following that vendor structure.
I'll test it again tomorrow.
I'll test it again tomorrow.
@sergeytolkachyov No need to do that. Your test is still valid, I restored the counter.
@richard67 what is currently missing for the merging of this pr?
@richard67 what is currently missing for the merging of this pr?
@sergeytolkachyov A 2nd human test. Your test still counts, but each PR needs 2 human tests before it is set to RTC (ready to commit). After that a maintainer will merge it whenever they find time.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39348.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39348.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39348.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-01-14 12:04:56 |
| Closed_By | ⇒ | roland-d |
Thank you
@SharkyKZ tested it successfully.