? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
1 Dec 2022

This fixes a bug exposed in my own pr #38447

That PR added an action dropdown button When you have overrides. See the original PR for details

However it also added the dropdown when the file was open for editing but at that point it can be selected because it is never active.

This PR removes the button when the file is open for editing.

A better PR would be to make it (or a similar button) work in the edit mode but I don't have the time (and probably the skill) to do that. So at this time I consider this PR a bug fix and the functionality can be added at a later date in another pr

Testing requires overrides that need checking. You can simulate this by

  1. Create template overrides for com_content/article and com_newsfeed/feed
  2. Run this sql query replacing #_ with your db prefix INSERT INTO #__template_overrides (id, template, hash_id, extension_id, state, action, client_id, created_date, modified_date) VALUES (1, 'cassiopeia', 'L2h0bWwvY29tX25ld3NmZWVkcy9uZXdzZmVlZC9kZWZhdWx0LnBocA==', 223, 0, 'Joomla Update', 0, '2022-09-01 13:51:54', '2022-09-01 13:51:54'), (2, 'cassiopeia', 'L2h0bWwvY29tX2NvbnRlbnQvYXJ0aWNsZS9kZWZhdWx0X2xpbmtzLnBocA==', 223, 0, 'Joomla Update', 0, '2022-09-01 13:51:54', '2022-09-01 13:51:54');

You will now have two override files to update and can test this PR

avatar brianteeman brianteeman - open - 1 Dec 2022
avatar brianteeman brianteeman - change - 1 Dec 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Dec 2022
Category Administration com_templates
avatar brianteeman brianteeman - change - 1 Dec 2022
Labels Added: ?
avatar richard67 richard67 - test_item - 11 Dec 2022 - Tested successfully
avatar richard67
richard67 - comment - 11 Dec 2022

I have tested this item successfully on c3e246c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39337.

avatar Kostelano Kostelano - test_item - 17 Dec 2022 - Tested successfully
avatar Kostelano
Kostelano - comment - 17 Dec 2022

I have tested this item successfully on c3e246c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39337.

avatar richard67 richard67 - change - 17 Dec 2022
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 17 Dec 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39337.

avatar roland-d roland-d - change - 18 Dec 2022
Labels Added: ?
avatar roland-d roland-d - change - 18 Dec 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-12-18 14:59:45
Closed_By roland-d
avatar roland-d roland-d - close - 18 Dec 2022
avatar roland-d roland-d - merge - 18 Dec 2022
avatar roland-d
roland-d - comment - 18 Dec 2022

Thank you

Add a Comment

Login with GitHub to post a comment