? ? Pending

User tests: Successful: Unsuccessful:

avatar ReLater
ReLater
29 Nov 2022

Summary of Changes

Allow tag <inheritable>0</inheritable> in templateDetails.xml. Use empty() instead of !isset().

Testing Instructions

<?xml version="1.0" encoding="utf-8"?>
<extension version="4.3" type="template">
	<name>nonamespacedummynoparent</name>
	<creationDate>2022-10-21</creationDate>
	<author>Me</author>
	<authorEmail>joomla@invalid.domain</authorEmail>
	<authorUrl>http://example.com</authorUrl>
	<copyright>Copyright (C) All rights reserved.</copyright>
	<version>1.0</version>
	<description>Test template for namespaces no namespace with no parent</description>
	<inheritable>0</inheritable>
	<files folder="templates/nonamespacedummynoparent">
		<folder>helpers</folder>
		<filename>index.php</filename>
		<filename>templateDetails.xml</filename>
	</files>

	<positions>
		<position>mainmenu</position>
	</positions>
</extension>
  • In backend go to templates (not styles).
  • Click template link "Nonamespacedummynoparent Details and Files"

Actual result BEFORE applying this Pull Request

A error message:

The template folder is not writable. Some features may not work.

grafik

Expected result AFTER applying this Pull Request

No error message

Comment

My build procedure for templates fills tags like inheritable using placeholders like <inheritable>{{inheritable}}</inheritable>. So I think values 0, 1, empty should be accepted without a misleading error message.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar ReLater ReLater - open - 29 Nov 2022
avatar ReLater ReLater - change - 29 Nov 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Nov 2022
Category Administration com_templates
avatar ReLater
ReLater - comment - 29 Nov 2022

BTW: The issue came up while testing #39011

avatar ReLater ReLater - change - 20 Dec 2022
Labels Added: ?
avatar Quy Quy - test_item - 24 Jan 2023 - Tested successfully
avatar Quy
Quy - comment - 24 Jan 2023

I have tested this item successfully on 9ae0b1e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39329.

avatar viocassel viocassel - test_item - 25 Jan 2023 - Tested successfully
avatar viocassel
viocassel - comment - 25 Jan 2023

I have tested this item successfully on 9ae0b1e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39329.

avatar Quy Quy - change - 25 Jan 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 25 Jan 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39329.

avatar fancyFranci fancyFranci - close - 3 Feb 2023
avatar fancyFranci fancyFranci - merge - 3 Feb 2023
avatar fancyFranci fancyFranci - change - 3 Feb 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-02-03 21:11:08
Closed_By fancyFranci
Labels Added: ?
avatar fancyFranci
fancyFranci - comment - 3 Feb 2023

One less error message. Thanks!

avatar ReLater
ReLater - comment - 25 Feb 2023

Please revert this pr. See #39934

avatar ReLater
ReLater - comment - 25 Feb 2023

See also pr #39943 that reverts this change in J!4.3

Add a Comment

Login with GitHub to post a comment