[#39317] - [4.2] missing rel="noopener noreferrer" in link language string
- Fixed in Code Base
- 28 Nov 2022
- Medium
- Build: 4.2-dev
- # 39317
- Diff
- sandewt:patch-6
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Add rel="noopener noreferrer" in language string
Testing Instructions
Code review
Actual result BEFORE applying this Pull Request
Missing rel="noopener noreferrer" in the language string, because the link contains target="_blank"
Expected result AFTER applying this Pull Request
Language string contains rel="noopener noreferrer"
Link to documentations
Please select:
-
No documentation changes for docs.joomla.org needed
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
| Title |
|
||||||
Do we have that string elsewhere, e.g. in the language file for the api client or the site, where it should be fixed, too? Am off my desk now so can’t comfortably check.
Update: I meanwhile checked. All fine, no other file with that string.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39317.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
Language Change
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39317.
Update: I meanwhile checked. All fine, no other file with that string.
@richard67 Thank you, your comment triggered me.
We missed the installation folder:
and
Update: I meanwhile checked. All fine, no other file with that string.
@richard67 Thank you, your comment triggered me.
We missed the installation folder:
and
@sandewt These are translations. If the English strings are ok, the translations have to be fixed on Crowdin, as far as I know.
If the English strings are ok, the translations have to be fixed on Crowdin, as far as I know.
I also found the same issue in a language pack. I will pass this on to the relevant translator.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-11-28 08:57:54 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
?
|
||
Thank you!
I have tested this item✅ successfully on 9649fd7
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39317.