Feeling Lucky
?
NPM Resource Changed
PR-4.3-dev
[#39312] - [4.3] joomla alert icons
- Fixed in Code Base
- 29 Aug 2023
- Medium
- Build: 4.3-dev
- # 39312
- Diff
- brianteeman:alert_line_height
User tests: Successful: Unsuccessful:
It always bugs me that the icon and text in the alert are off-center. (and someone else because there was an issue in the past but I cant find it now).
This simple PR sets the correct line height which re-centers the icon which I assume was the original intent based on the original css and the bootstrap alert it is inspired by.
To test you will need to either use a prebuilt package or apply the pr and npm run build:css
Before
After
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
PR-4.3-dev
|
||
| Title |
|
||||||
RickR2H
- comment
- 26 Aug 2023
I have tested this item ✅ successfully on 8489df2
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39312.
| Status | Pending | ⇒ | Ready to Commit |
RickR2H
- comment
- 26 Aug 2023
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39312.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-08-29 02:17:51 |
| Closed_By | ⇒ | obuisard |
obuisard
- comment
- 29 Aug 2023
Thank you Brian @brianteeman !
I have tested this item ✅ successfully on 8489df2
On Joomla 4.4.dev with php 8.1.22
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39312.