[#3930] - Use $this->params insteand $app->getTemplate(true)->params at the templates
- Closed
- 23 Sep 2014
- Medium
- Build: staging
- # 3930
- Diff
- zero-24:patch-8
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
As requested (#3782 (diff)) see here @bakual
old PR: #3791
I'll review and merge it after we have released 3.3.2. Should be fine without a tracker imho, it's basically similar to a codestyle PR.
brianteeman
- | Labels |
Added:
?
|
||
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-08-06 19:22:11 |
| Status | Closed | ⇒ | New |
| Labels |
Removed:
?
|
||
This has an issue with the error pages. Looks like $this->params isn't set there.
Looks like $this->params is only always set in the regular HTML page using the index.php file (done by JDocumentHtml). It isn't set for the error page using error.php (done by JDocumentError).
So the changes in the main files in Beez and Protostar would be fine, the ones in the error pages are not.
Woops. Yes your are right. I have revert the changes for the error pages.
| Status | New | ⇒ | Pending |
nicksavov
- | Labels |
Removed:
?
|
||
| Category | ⇒ | Template |
| Category | ⇒ | Code style |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 2014-08-06 19:22:11 | ⇒ | 2014-09-23 19:43:12 |
Tracker?