[#39287] - Add a prefix (editor name) to buttons modal id
- Fixed in Code Base
- 29 Nov 2022
- Medium
- Build: 4.2-dev
- # 39287
- Diff
- OctavianC:button-modal-ids
User tests: Successful: Unsuccessful:
Pull Request for Issue #39277 .
Summary of Changes
Noticed that TinyMCE works because it adds a prefix to the ID of the button: https://github.com/joomla/joomla-cms/blob/4.2-dev/plugins/editors/tinymce/src/PluginTraits/XTDButtons.php#L69
So I've globally added the same prefix (the editor ID) to the button modal's ID. This way, Bootstrap::renderModal() will always add the HTML on the page when multiple editors are used.
Testing Instructions
See #39277
TLDR: have multiple tabs, an editor on the first tab, a separate editor on the second tab. Second editor buttons (editors-xtd) don't work because first tab is hidden and holds the modal.
Actual result BEFORE applying this Pull Request
Overlay shows, but no modal (it's hidden by the first tab, where it's located):
Expected result AFTER applying this Pull Request
Works:
Please test with 3rd party editors and editor buttons in case I've broken something, I've only tested with default Joomla! extensions.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout Libraries |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39287.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39287.
@Fedik or @dgrammatiko can one of you guys approve this?
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-11-29 22:25:48 |
| Closed_By | ⇒ | fancyFranci |
Thanks a lot for fixing this! :)
I have tested this item✅ successfully on 6e062c2
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39287.