Joomla! Issue Tracker | Joomla! CMS #39261 - [4.3] Redis cache PR #38490 for 4.3 branch

PR-4.3-dev

Fixed in Code Base
20 Nov 2022
Medium
Build: 4.3-dev
# 39261
Diff
heelc29:4.3/patch-38490

Pending

User tests: Successful: Unsuccessful:

heelc29
20 Nov 2022

Pull Request for Pull Reqest #38490

Summary of Changes

Apply changes from PR #38490 to 4.3 branch.

These changes should have been committed in the upmerge (#38557), but may have been missed due conflict resolution @obuisard.

Testing Instructions

see #38490 or code review because code is already included in 4.2

Actual result BEFORE applying this Pull Request

joomla-cms/libraries/src/Version.php

Lines 309 to 314 in 7a3a985

    
           /** @var CallbackController $cache */ 
        
           $cache = Factory::getContainer()->get(CacheControllerFactoryInterface::class) 
        
               ->createCacheController('callback', ['defaultgroup' => '_media_version', 'caching' => true]); 
        
           // Media version cache never expire 
        
           $cache->setLifeTime(INF);

Expected result AFTER applying this Pull Request

Like 4.2

joomla-cms/libraries/src/Version.php

Lines 309 to 313 in 06038e5

    
           /** @var CallbackController $cache */ 
        
           $cache = Factory::getContainer()->get(CacheControllerFactoryInterface::class) 
        
               ->createCacheController('callback', ['defaultgroup' => '_media_version', 'caching' => true]); 
        
           $cache->setLifeTime(315576000);

74a8da0 20 Nov 2022

[4.3] Redis cache

heelc29 - open - 20 Nov 2022

heelc29 - change - 20 Nov 2022

Status

New

⇒

Pending

joomla-cms-bot - change - 20 Nov 2022

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#39261] - [4.3] Redis cache PR #38490 for 4.3 branch

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Add a Comment

	/** @var CallbackController $cache */
	$cache = Factory::getContainer()->get(CacheControllerFactoryInterface::class)
	->createCacheController('callback', ['defaultgroup' => '_media_version', 'caching' => true]);

	// Media version cache never expire
	$cache->setLifeTime(INF);

Status	Pending	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2022-11-20 16:43:19
Closed_By		⇒	obuisard