Language Change PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
20 Nov 2022

Summary of Changes

Re-add info to COM_TAGS_ERROR_UNIQUE_ALIAS for tag alias (#38576) added by @brianteeman and removed during Upmerge (#38973) by @obuisard .

image

The change in PR #37017 (for 4.2), also by @brianteeman, was just splitting it into two separate language strings:
image

EDIT:
I saw also later the specifier for formatted strings was also reverted from PR #38267
image

Testing Instructions

Create two tags with the same parent and the same alias.
Note: If the parent tag is different, it now works in 4.3.

Enable Tags Icon with Show Items with Count in any Quickicon module.

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

and when the other tag is trashed
image

Check the information for the screenreader of the tags quickicon, if the number of tags is still in the output like this or with a real screenreader:
<div class="quickicon-sr-desc visually-hidden">Tags: 2 tags are published.</div>

avatar heelc29 heelc29 - open - 20 Nov 2022
avatar heelc29 heelc29 - change - 20 Nov 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Nov 2022
Category Administration Language & Strings
avatar heelc29 heelc29 - change - 20 Nov 2022
Labels Added: Language Change PR-4.3-dev
avatar heelc29 heelc29 - change - 20 Nov 2022
The description was changed
avatar heelc29 heelc29 - edited - 20 Nov 2022
avatar obuisard obuisard - change - 20 Nov 2022
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-11-20 15:14:48
Closed_By obuisard
avatar obuisard obuisard - close - 20 Nov 2022
avatar obuisard obuisard - merge - 20 Nov 2022
avatar obuisard
obuisard - comment - 20 Nov 2022

Thank you @heelc29 for catching that error

Add a Comment

Login with GitHub to post a comment