[#3925] - Update template.less
- Closed
- 1 Jan 2015
- Medium
- Build: staging
- # 3925
- Diff
- nyocca:patch-1
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Change position of navbar to static rather than fixed, permitting scrolling of navbar and connected dropdown menus, on desktop view (which conforms desktop with tablet and phone views).
Make optional change in phone and tablet view that conforms with stick toolbar of desktop view.
It is advised to use cli after updating the less file:
php build/generatecss.php
Thank you all for the correction to my choice, you have tremendously shrunken my knowledge gap with your capable guidance. I only had one day's worth of experience and now I have my second day's worth, and I started from zero, and in between I work as a business attorney.
I look forward to the next time. I appreciate, really, your patience. You are good folks to suffer through dealing with people such as me who have zero background.
| Status | New | ⇒ | Pending |
nicksavov
- | Labels |
Removed:
?
|
||
| Category | ⇒ | Template |
| Category | ⇒ | Templates (admin) |
| Labels |
Added:
?
|
||
@success +1
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3925.
Just tested this and yes the code changed from fixed to static, but it caused another issue - so the patch is not complete. See screenshot for more info.
Another thing, I can't actually see why this should be changed to static?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3925.
@jerrychr can you have another go at sending the screenshot please
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3925.
@brianteeman - there you go
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3925.
@jerrychr thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3925.
I get the same result as @JerryChr
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3925.
@nyocca as this pull request is not working correctly (see screenshots above) please can you have another go.
I am setting this to information required an if not updated within the next few weeks it will be closed.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3925.
| Status | Pending | ⇒ | Information Required |
| Labels |
Removed:
?
|
||
After considerable time without update I am closing this. If you update the pr as requested it can always be reopened
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3925.
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-01-01 16:56:29 |
| Closed_By | ⇒ | brianteeman |
| Closed_Date | 2015-01-01 16:56:29 | ⇒ | 2015-01-01 16:56:30 |
Thanks for your patch. As .css files are genetated compiling LESS files can you update the source at:
https://github.com/joomla/joomla-cms/blob/staging/administrator/templates/isis/less/template.less
If not next time it's recompiled your contribution will be lost