[#39224] - [4.3] Mark deprecation in DelegatingPsrLogger
- Fixed in Code Base
- 22 Nov 2022
- Medium
- Build: 4.3-dev
- # 39224
- Diff
- nikosdion:architecture/j43-psrlogger-prep
User tests: Successful: Unsuccessful:
See #39134 (comment)
Summary of Changes
\Joomla\CMS\Log\DelegatingPsrLogger was marked @internal and a deprecation notice information developers it will be marked final has been added.
Testing Instructions
None. This PR only changes the DocBlock.
Link to documentations
Please select:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org: PR 61
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
The idea is that if someone does Whatever extends \Joomla\CMS\Log\DelegatingPsrLogger we want them to get the big strikethrough and warning in their IDE, hinting them that something is changing. Hopefully they will look at the core class and figure out what the deprecation is.
In the PR for 5.0 the deprecation is removed. The class is made final and the @internal mark is kept.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-11-22 13:37:13 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
PR-4.3-dev
|
||
Thanks
I'm probably being overly pedantic here but isn't this better off as a note rather than deprecated. Because people will still be able to init the class and it's not deprecated (in the short term anyhow) for that purpose?