? Maintainers Checked PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
10 Nov 2022

Pull Request for Issue #39182 .

Summary of Changes

When the language code was removed from the filenames of the translation files, this code was forgotten.

Testing Instructions

Install a language with commonwords file. Check in #__finder_terms_common if the words are there. After applying the patch, install the language again and check if the words are present now.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 10 Nov 2022
avatar Hackwar Hackwar - change - 10 Nov 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Nov 2022
Category Front End Plugins
avatar Hackwar Hackwar - change - 11 Nov 2022
Labels Added: Maintainers Checked PR-4.3-dev
avatar heelc29 heelc29 - test_item - 13 Nov 2022 - Tested unsuccessfully
avatar heelc29
heelc29 - comment - 13 Nov 2022

I have tested this item ? unsuccessfully on 461d591

It will work, when I install only the site language. When I install the language pack (for example german) the common words will added when site language is install, but after the administrator (or api) language will be installed and the words will be deleted again. The order of installation will depend on the package manifest.

https://github.com/joomlagerman/joomla/blob/fef13226151af2fd5a6a73e30998d309c06befde/pkg_de-DE.xml#L26-L30


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39188.

avatar Hackwar
Hackwar - comment - 14 Nov 2022

I moved the removal of the words upon installation to a point where it is only executed if new words are added again. This leaves the problem that when you install a language pack and then uninstall single languages again (for example because you don't need them in the backend), the common words would be removed as well.

avatar richard67
richard67 - comment - 14 Nov 2022

I moved the removal of the words upon installation to a point where it is only executed if new words are added again. This leaves the problem that when you install a language pack and then uninstall single languages again (for example because you don't need them in the backend), the common words would be removed as well.

Is ok for me.

@heelc29 Is that ok for you, too, and would this revert your negative test result and would it also close issue #39182 ?

avatar heelc29 heelc29 - test_item - 16 Nov 2022 - Tested successfully
avatar heelc29
heelc29 - comment - 16 Nov 2022

I have tested this item successfully on 624b7d0

Works and closes #39182.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39188.

avatar viocassel viocassel - test_item - 18 Nov 2022 - Tested successfully
avatar viocassel
viocassel - comment - 18 Nov 2022

I have tested this item successfully on 624b7d0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39188.

avatar alikon alikon - change - 18 Nov 2022
Status Pending Ready to Commit
avatar alikon
alikon - comment - 18 Nov 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39188.

avatar obuisard obuisard - change - 18 Nov 2022
Labels Added: ?
avatar obuisard obuisard - change - 18 Nov 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-11-18 18:15:57
Closed_By obuisard
avatar obuisard obuisard - close - 18 Nov 2022
avatar obuisard obuisard - merge - 18 Nov 2022
avatar obuisard
obuisard - comment - 18 Nov 2022

Thank you again Hannes @Hackwar

Add a Comment

Login with GitHub to post a comment