User tests: Successful: Unsuccessful:
Pull Request for Issue #39182 .
When the language code was removed from the filenames of the translation files, this code was forgotten.
Install a language with commonwords file. Check in #__finder_terms_common if the words are there. After applying the patch, install the language again and check if the words are present now.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Front End Plugins |
Labels |
Added:
Maintainers Checked
PR-4.3-dev
|
I moved the removal of the words upon installation to a point where it is only executed if new words are added again. This leaves the problem that when you install a language pack and then uninstall single languages again (for example because you don't need them in the backend), the common words would be removed as well.
I moved the removal of the words upon installation to a point where it is only executed if new words are added again. This leaves the problem that when you install a language pack and then uninstall single languages again (for example because you don't need them in the backend), the common words would be removed as well.
Is ok for me.
@heelc29 Is that ok for you, too, and would this revert your negative test result and would it also close issue #39182 ?
I have tested this item
Works and closes #39182.
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-11-18 18:15:57 |
Closed_By | ⇒ | obuisard |
I have tested this item? unsuccessfully on 461d591
It will work, when I install only the site language. When I install the language pack (for example german) the common words will added when
site
language is install, but after theadministrator
(orapi
) language will be installed and the words will be deleted again. The order of installation will depend on the package manifest.https://github.com/joomlagerman/joomla/blob/fef13226151af2fd5a6a73e30998d309c06befde/pkg_de-DE.xml#L26-L30
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39188.