The plugin is searching for a commonwords
file like in that folder(/administrator)/language/xx-xx/xx-xx.com_finder.commonwords.txt
joomla-cms/plugins/extension/finder/finder.php
Lines 139 to 143 in 9cbe6cb
language/en-GB/en-GB.com_finder.commonwords.txt
to language/en-GB/com_finder.commonwords.txt
in PR #27130
A language pack consists of three parts site
, admin
, api
. Even if the site language contains the file (with correct file name), they will be deleted again if the admin/api language is installed afterwards
joomla-cms/plugins/extension/finder/finder.php
Lines 57 to 60 in 9cbe6cb
Plugin should work as expected (when commonwords are needed)
J4.x
cc @Hackwar
Labels |
Added:
No Code Attached Yet
|
@Hackwar @heelc29 Would it be a solution for the 2nd part of the issue if we do the removeCommonWords
and addCommonWords
only when the client of the extension is equal to 'site'?
Currently when installing a complete language pack we can rely on the site client being installed as last because it comes as last in the alphabetical order of the clients (administrator, api, site). But there is still the possibility that people install languages separately and not as package. And if in future someone invents a new client named 'whatever' we will have the problem again, too.
The order of installation will depend on the package manifest.
Additional note about client ids:
0 = site
1 = administrator
2 = installation
3 = api
See #39188 (comment)
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-11-16 20:27:18 |
Closed_By | ⇒ | heelc29 |
I fixed the first part in #39188, but regarding the second complaint, I'm calling this by design. It is not as if the common words would make a big difference or something and I expect there to be just one such file in the different language files.