User tests: Successful: Unsuccessful:
Pull Request for Issue #19085.
When uninstalling an extension of type file
with a script file, the preflight, postflight and actual uninstall methods are not called. The (un)installer is loading the right manifest and even the right script file, but doesn't look for the right classname.
Get a random extension of type file
and add an install script by adding <scriptfile>example.script.php</scriptfile>
to the manifest and for example the attached script file example.script.php.txt (You have to rename it and remove the .txt at the end. Also make sure that you adapt the scripts class name to your file extensions manifest name.)
Installing shows preflighttestpostflight
as install message. Uninstall doesn't show anything.
Both installing and uninstalling shows preflighttestpostflight
as (un)install message.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
Labels |
Added:
PR-4.3-dev
|
Yes, it is a bugfix. I'm just doing this for 4.3 because for me it is easier and I have more trust in the CI setup for 4.3 with the changes in the last few weeks. Looking at the rate at how my PRs are tested, it will be merged into 5.0 anyway, so why bother with setting it to 4.2-dev and then rebasing it every 6 months?
Well I only asked in order to understand.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-04-18 12:06:34 |
Closed_By | ⇒ | Hackwar | |
Labels |
Added:
bug
?
|
Why closed? Should we reopen the original issue?
Title |
|
Status | Closed | ⇒ | New |
Closed_Date | 2023-04-18 12:06:34 | ⇒ | |
Closed_By | Hackwar | ⇒ |
Status | New | ⇒ | Pending |
Labels |
Added:
PR-5.0-dev
Removed: PR-4.3-dev |
Leave it as the branch is already updated.
Labels |
Added:
J4 Issue
PBF
Maintainers Checked
?
Removed: ? |
Labels |
Added:
Small
Removed: ? |
I have tested this item ✅ successfully on 1e59233
I have tested this item ✅ successfully on 1e59233
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
RTC
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-02-01 18:32:40 |
Closed_By | ⇒ | bembelimen |
Thx
Why for the 4.3-dev branch and not 4.2-dev? As far as I understand it's a bug fix.