RTC J4 Issue PBF bug Maintainers Checked PR-5.0-dev Small Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
8 Nov 2022

Pull Request for Issue #19085.

Summary of Changes

When uninstalling an extension of type file with a script file, the preflight, postflight and actual uninstall methods are not called. The (un)installer is loading the right manifest and even the right script file, but doesn't look for the right classname.

Testing Instructions

Get a random extension of type file and add an install script by adding <scriptfile>example.script.php</scriptfile> to the manifest and for example the attached script file example.script.php.txt (You have to rename it and remove the .txt at the end. Also make sure that you adapt the scripts class name to your file extensions manifest name.)

Actual result BEFORE applying this Pull Request

Installing shows preflighttestpostflight as install message. Uninstall doesn't show anything.

Expected result AFTER applying this Pull Request

Both installing and uninstalling shows preflighttestpostflight as (un)install message.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 8 Nov 2022
avatar Hackwar Hackwar - change - 8 Nov 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Nov 2022
Category Libraries
avatar Hackwar Hackwar - change - 9 Nov 2022
Labels Added: PR-4.3-dev
avatar richard67
richard67 - comment - 10 Nov 2022

Why for the 4.3-dev branch and not 4.2-dev? As far as I understand it's a bug fix.

avatar Hackwar
Hackwar - comment - 10 Nov 2022

Yes, it is a bugfix. I'm just doing this for 4.3 because for me it is easier and I have more trust in the CI setup for 4.3 with the changes in the last few weeks. Looking at the rate at how my PRs are tested, it will be merged into 5.0 anyway, so why bother with setting it to 4.2-dev and then rebasing it every 6 months?

avatar richard67
richard67 - comment - 10 Nov 2022

Well I only asked in order to understand.

avatar Hackwar Hackwar - change - 18 Apr 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-04-18 12:06:34
Closed_By Hackwar
Labels Added: bug ?
avatar Hackwar Hackwar - close - 18 Apr 2023
avatar richard67
richard67 - comment - 18 Apr 2023

Why closed? Should we reopen the original issue?

avatar Hackwar Hackwar - change - 18 Apr 2023
Title
[4.3] Find proper script for file uninstall
[5.0] Find proper script for file uninstall
avatar Hackwar Hackwar - edited - 18 Apr 2023
avatar Hackwar Hackwar - change - 18 Apr 2023
Status Closed New
Closed_Date 2023-04-18 12:06:34
Closed_By Hackwar
avatar Hackwar Hackwar - change - 18 Apr 2023
Status New Pending
avatar Hackwar Hackwar - reopen - 18 Apr 2023
avatar Hackwar Hackwar - change - 30 May 2023
Labels Added: PR-5.0-dev
Removed: PR-4.3-dev
avatar HLeithner
HLeithner - comment - 5 Oct 2023

@MacJoom @laoneo would you like to move this to 4.4?

avatar laoneo
laoneo - comment - 5 Oct 2023

Leave it as the branch is already updated.

avatar Hackwar Hackwar - change - 3 Nov 2023
Labels Added: J4 Issue PBF Maintainers Checked ?
Removed: ?
avatar Hackwar Hackwar - change - 25 Dec 2023
Labels Added: Small
Removed: ?
avatar bembelimen bembelimen - test_item - 31 Dec 2023 - Tested successfully
avatar bembelimen
bembelimen - comment - 31 Dec 2023

I have tested this item ✅ successfully on 1e59233


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39180.

avatar viocassel viocassel - test_item - 16 Jan 2024 - Tested successfully
avatar viocassel
viocassel - comment - 16 Jan 2024

I have tested this item ✅ successfully on 1e59233


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39180.

avatar richard67 richard67 - change - 16 Jan 2024
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 16 Jan 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39180.

avatar Quy Quy - change - 20 Jan 2024
Labels Added: RTC
avatar bembelimen bembelimen - close - 1 Feb 2024
avatar bembelimen bembelimen - merge - 1 Feb 2024
avatar bembelimen bembelimen - change - 1 Feb 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-02-01 18:32:40
Closed_By bembelimen
avatar bembelimen
bembelimen - comment - 1 Feb 2024

Thx

Add a Comment

Login with GitHub to post a comment