? Maintainers Checked PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
7 Nov 2022

Summary of Changes

Migrate the quickicon downloadkey plugin to service providers and use SubscriberInterface.

Testing Instructions

  • Install an extension with providing a download key
  • Check if quickicons are still working

image
image

Actual result BEFORE applying this Pull Request

Downloadkey quickicon is working

Expected result AFTER applying this Pull Request

Downloadkey quickicon is working (and the other quickicons are still displayed)

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar heelc29 heelc29 - open - 7 Nov 2022
avatar heelc29 heelc29 - change - 7 Nov 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Nov 2022
Category Front End Plugins
avatar laoneo
laoneo - comment - 8 Nov 2022

I have tested this item successfully on 3ad401b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39168.

avatar laoneo laoneo - test_item - 8 Nov 2022 - Tested successfully
avatar heelc29 heelc29 - change - 8 Nov 2022
Labels Added: PR-4.3-dev
avatar heelc29
heelc29 - comment - 8 Nov 2022

Guess this here should be lower case as well

Done

avatar Abernyte-Git
Abernyte-Git - comment - 8 Nov 2022

I have tested this item successfully on 254dcee


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39168.

avatar Abernyte-Git Abernyte-Git - test_item - 8 Nov 2022 - Tested successfully
avatar alikon alikon - alter_testresult - 8 Nov 2022 - laoneo: Tested successfully
avatar alikon alikon - change - 8 Nov 2022
Status Pending Ready to Commit
avatar alikon
alikon - comment - 8 Nov 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39168.

avatar obuisard obuisard - change - 9 Nov 2022
Labels Added: ? Maintainers Checked
avatar obuisard obuisard - change - 9 Nov 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-11-09 17:08:06
Closed_By obuisard
avatar obuisard obuisard - close - 9 Nov 2022
avatar obuisard obuisard - merge - 9 Nov 2022
avatar obuisard
obuisard - comment - 9 Nov 2022

Great work @heelc29. Thank you!

avatar heelc29
heelc29 - comment - 9 Nov 2022

Thanks

Add a Comment

Login with GitHub to post a comment