[#39158] - [4][com_categories] Verify that the alias is unique before batch move
- Fixed in Code Base
- 12 Nov 2022
- Medium
- Build: 4.2-dev
- # 39158
- Diff
- alikon:patch-16
User tests: Successful: Unsuccessful:
Pull Request for Issue #39137
Summary of Changes
Verify that the alias is unique before batch move
Testing Instructions
see #39137
Actual result BEFORE applying this Pull Request
categories moved even with same alias
Expected result AFTER applying this Pull Request
not moved cause of same alias
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_categories |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39158.
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39158.
Before PR:
With Patch:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39158.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39158.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-11-12 16:21:53 |
| Closed_By | ⇒ | richard67 |
Thanks all.
Sorry I missed this. We should be careful here. Adding the check is good but as we're batch moving and may already have stored previous batch categories if we're doing multiple we need to specify which category failed in the error. We should also probably note some categories may have successfully completed batch (we can use a Boolean to detect this). Potentially we could use continue for the for loop rather than returning false so we continue onto other items and list the ones that already exist
verifikasi
I have tested this item✅ successfully on ffe8ed7
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39158.