? PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
5 Nov 2022

Summary of Changes

While working on the tags, I noticed that the menu system is missing a rebuild upon saving an item. We have this code in com_categories and in com_tags. Without this, errors in the tree are not fixed upon saving the item again.

Testing Instructions

In a website with a few menu items, change the lft and rgt value from a menu item to 0. Edit that menu item and save it again. See that the lft and rgt values are restored.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 5 Nov 2022
avatar Hackwar Hackwar - change - 5 Nov 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Nov 2022
Category Administration com_menus
avatar chmst
chmst - comment - 5 Nov 2022

Would this mean that we can remove the rebuild button?

avatar Hackwar
Hackwar - comment - 5 Nov 2022

I fear not. It is present everywhere else, so for now I would keep both... In the long run I'd like to have a maintenance component where stuff like this would be moved to. But that's far into the future.

avatar Hackwar Hackwar - change - 9 Nov 2022
Labels Added: PR-4.3-dev
avatar Hackwar Hackwar - change - 9 Nov 2022
The description was changed
avatar Hackwar Hackwar - edited - 9 Nov 2022
avatar chmst chmst - test_item - 23 Nov 2022 - Tested successfully
avatar chmst
chmst - comment - 23 Nov 2022

I have tested this item successfully on b22ab63


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39153.

avatar viocassel viocassel - test_item - 27 Nov 2022 - Tested successfully
avatar viocassel
viocassel - comment - 27 Nov 2022

I have tested this item successfully on b22ab63


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39153.

avatar richard67 richard67 - change - 27 Nov 2022
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 27 Nov 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39153.

avatar laoneo laoneo - change - 28 Nov 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-11-28 09:01:14
Closed_By laoneo
Labels Added: ?
avatar laoneo laoneo - close - 28 Nov 2022
avatar laoneo laoneo - merge - 28 Nov 2022
avatar laoneo
laoneo - comment - 28 Nov 2022

Thank you!

Add a Comment

Login with GitHub to post a comment