No Code Attached Yet bug
avatar coolcat-creations
coolcat-creations
4 Nov 2022

Steps to reproduce the issue

Create at least two Categories
Create a Menu item and link it with Category Blog to one of the Categories
In the Menu item click on "edit" next to the Category Field and rename the category and its alias to the other existing category

Expected result

The expected result is that you cannot save and close this because a error message should appear and prevent the dialog from Save and close because the category name / alias is taken. Sometimes the error even shortly appears before the modal closes. But it's going to fast to recognize. On a fast Server you don't see an error at all.

Actual result

In this Video it looks like renaming was successful but it isn't because the category name is taken:
https://vimeo.com/767253215/034c0e05a6

System information (as much as possible)

Joomla 4.2.4
PHP 8.0

Additional comments

It was an UX Flaw during Joomla4Kids Week

avatar coolcat-creations coolcat-creations - open - 4 Nov 2022
avatar joomla-cms-bot joomla-cms-bot - change - 4 Nov 2022
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 4 Nov 2022
avatar coolcat-creations coolcat-creations - change - 4 Nov 2022
The description was changed
avatar coolcat-creations coolcat-creations - edited - 4 Nov 2022
avatar chmst
chmst - comment - 5 Nov 2022

Confirmed. The modal must remain open when a message is active.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39150.

avatar chmst chmst - change - 5 Nov 2022
Labels Added: bug
avatar chmst chmst - labeled - 5 Nov 2022
avatar heelc29
heelc29 - comment - 7 Nov 2022

Please test #39173

avatar alikon
alikon - comment - 7 Nov 2022

closing as we have a pr to test #39173

avatar alikon alikon - change - 7 Nov 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-11-07 16:08:38
Closed_By alikon
avatar alikon alikon - close - 7 Nov 2022
avatar wojtekxtx
wojtekxtx - comment - 7 Nov 2022

@alikon As #39173 is not merged, this issue is not completed. Do not close issues when related PR has not been merged/closed w/o merging.

Use linking to relate issues to PRs. This way once all linked PRs gets merged, all issues linked from within gets closed alltogether.

avatar brianteeman
brianteeman - comment - 7 Nov 2022

no -

avatar wojtekxtx
wojtekxtx - comment - 7 Nov 2022

@brianteeman what?

avatar alikon
alikon - comment - 8 Nov 2022

@wojtekxtx we close an issue when there is a pull request

please test it #39173
thanks in advance

avatar wojtekxtx
wojtekxtx - comment - 8 Nov 2022

@alikon linking was introduced by GitHub for a reason. Not because they had to for the sake of introducing..... btw its very useful in scenerios like here.

Your current way of doing things is, well, stupid.

avatar coolcat-creations
coolcat-creations - comment - 8 Nov 2022

@wojtekxtx it was always done like that in Joomla, but I like the way you describe more, maybe there is a way to change this process in Joomla because this way, when a PR got closed, weh still know the issue still exists. @bembelimen

+would be great if duplicate reports would not be just closed but merged or something so we know that many people have this issue

avatar brianteeman
brianteeman - comment - 8 Nov 2022

If a pr is closed without merging the original issue is always reopened.

If an issue is closed as a duplicate it is always linked to the original.

This way discussion on the fix only occurs in one place

Add a Comment

Login with GitHub to post a comment