[#39142] - [4.2] Template Preview modal
- Fixed in Code Base
- 18 Dec 2022
- Medium
- Build: 4.2-dev
- # 39142
- Diff
- brianteeman:element
User tests: Successful: Unsuccessful:
It is possible that the template->name does not match the template->element
When that is the case then it is not possible to open the larger preview image of the template as the id of the modal is not the same as the id referenced in the button.
This PR corrects that by using template->element in both places.
To test
The easiest way will be to create a child of cassiopeia and then edit the database.
in #__extensions find the record for the child template and change the name only.
Now in the admin template manager you will find that you get a js error when you try to open the larger preview image.
Apply this PR and you will find that the preview opens correctly
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_templates |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39142.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39142.
| Labels |
Added:
?
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-12-18 15:33:14 |
| Closed_By | ⇒ | roland-d |
Thank you
I have tested this item✅ successfully on 55f6c52
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39142.