No Code Attached Yet
avatar Scrabble96
Scrabble96
2 Nov 2022

I've been going through a load of template changed files - mostly switching tabs to spaces, but noticed some formatting inconsistencies:

What needs to be fixed

lines 93-94, 115-116 and 137-138 of components/com_content/tmpl/article/default.php all start like this:
<?php
if ...

and lines 96-97 are like this:
endif;
?>

Why this should be fixed

Other instances of this code - for example in blog.php or featured/default.php - are like this:
<?php if ...

and for lines 96-97:
endif; ?>
like all other instances in this file

How would you fix it

Merge lines together

Side Effects expected

None

avatar Scrabble96 Scrabble96 - open - 2 Nov 2022
avatar joomla-cms-bot joomla-cms-bot - change - 2 Nov 2022
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 2 Nov 2022
avatar Hackwar Hackwar - change - 22 Feb 2023
Labels Added: bug
avatar Hackwar Hackwar - labeled - 22 Feb 2023
avatar brianteeman
brianteeman - comment - 26 Feb 2023

its not just the lines you highlight that are inconsistent :(

avatar chmst chmst - change - 20 Feb 2024
Status New Closed
Closed_Date 0000-00-00 00:00:00 2024-02-20 21:25:12
Closed_By chmst
avatar chmst chmst - close - 20 Feb 2024
avatar chmst
chmst - comment - 20 Feb 2024

There are countless small similiar discrepancies in layout files, because there were many different contributors and the code was written over a long time.
Maintainers discussed your issue and we decided to close it because we don't see this as bugs (they don't give wrong results or break the function).

avatar chmst chmst - change - 20 Feb 2024
Labels Removed: bug
avatar chmst chmst - unlabeled - 20 Feb 2024

Add a Comment

Login with GitHub to post a comment