User tests: Successful: Unsuccessful:
Update dependencies, proof of concept.
@nikosdion does this work for you?
Status | New | ⇒ | Pending |
Category | ⇒ | External Library Composer Change |
Sorry i didn't mentioned I released joomla/applications with PSR/log support 2.0 and 3.0 yesterday
OK, that is the actual fix for the problem :) I had gone as far as you went in this PR here but without support from joomla/application I was dead in the water. In this case, yes, what you did looks good to me. If you could please merge your PR I can work on fixing the WebAuthn code on our consumer side.
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-11-02 08:56:26 |
Closed_By | ⇒ | HLeithner | |
Labels |
Added:
Composer Dependency Changed
PR-5.0-dev
|
Ok thanks merged, I was also thinking about requiring 5.0 of webauthn lib but since it's not tagged yet I was unsure if it's stable enough. Also I don't know if it has other breaking changes relevant for us. Maybe you can have a look?
I would rather wait to see how the WebAuthn library looks after they tag 5.0.0.
There were two big changse from 1.x to 2.x. For starters, the abstraction was polished and then remained pretty much the same between 2.x and 4.x. I don't expect it to change too much. The other big change was the data stored in the database; arguably, the data stored in 1.x was unnecessary and complicated, it was simplified in 2.x and remained steady. Therefore I do not expect any major changes on our consumer side if / when we upgrade to 5.x.
No, this doesn't work. If you upgrade psr/log you can no longer install joomla/application which has a hard requirement for psr/log 1.x.
This is the exact problem I told you about.
Delete libraries/vendor and run composer update psr/log. You'll see the problem.