Great stuff. Really looking forward to this. Just wondering if it should use the same ui as versioning in com_content etc?

This PR is missing the update sql

Module params really should be passed through JText

When testing a "custom html" module the content really should be displayed readonly/disabled.

For example the welcome to joomla module in the sample data has a button in the content. As it is active you can click on it - and then that produces an error

Module Settings - This runs through JText which is great but you also need to ensure that the access level is displayed correctly

It is not clear that the first link is just for checking the radio or that there even is a second clickable link

When the module param is stored in the database as a 0 it is not displayed in the versions

Because the UI doesnt allow you to compare two versions it makes it very hard to see what has changed

There needs to be a process that creates entries in the module_versions table for all existing modules when joomla is updated to a version that includes this plugin.

Otherwise what happens is that you open an existing article, make a change and save.
there is now ONE entry in the versions table. so if you click on the versions button it will only show you the current version and not the previous version

The most important thing for me would be to see any changes in the menu assignment. this is completely missing

Start and finish publishing. This is missing

Frontend Module changes

If you edit a module in the frontend then a change is not recorded in the module_versions table

Resolving all of the above and this will be an awesome addition

Resolving all of the above and this will be an awesome addition

Resolving all of the above and this will be an awesome addition

Thank you, Brian @brianteeman , very thorough walkthrough, appreciated!

Why are you not using the version system we have already? Putting that functionality into a system plugin which gets loaded on every page is a wrong approach. This should all be built into the modules component and not into a plugin. What is the reason to have this in a system plugin?

Sorry I forgot to let you know what a better way is. You should look into the contenthistory component how it is done for content. What you also have to do is to save the modules in the history table, add a version to the modules table, maybe also to the modules to menu table. Then make sure only the module with the higest version is loaded. And I am sure I forget something but this should be the way to go.

I am going to close this PR.

Thank you all for the feedback, it is much appreciated.

Thank you to Rick @RickR2H who took the time to improve on a his own project and for providing it to Joomla. This feature has been introduced after listening to feedback from users. Let's rework it and introduce it soon!

For people interested in using this plugin on there site, please go to https://github.com/R2H-BV/moduleversion/releases to download the latest version. @brianteeman thanks for all your feedback. I'll try to implement the things mentioned by you.