Summary of Changes

This is the result of a codereview of the tag view from com_tags. There are several changes in here, which fix broken behavior in this one view and clean up code. I'm doing my best to document everything in here... This is a complex change, but unfortunately I don't see how to simplify this and/or split this up into several PRs. For all existing sites, this PR will not result in new errors, but rather fix existing issues.

Let's start into the changes in here:

• The view class has been reordered to mimic the article view of com_content. This means, that data is assigned directly to a class attribute and not to a temporary variable, after the data is collected from the model, the parameters are merged appropriately and then the plugin events are run.
• A bunch of docblocks have been fixed.
• The feature to count hits on tags has been moved from the view to the controller, similar to how it is done in com_content. An option to disable this has been added as well.
• $this->item in the view class contains an array of tags and up till now only the first tag was checked against the menu item, etc. Now all the tags are checked.
• At several places, the view class checked the access levels. This is something that we are doing in the model (already) not in the view.
• Merging of parameters was unnecessarily complex.
• In the tag model, the $item attribute wasn't defined. $tag at the same time wasn't used. With $item being initialised as an array, we can remove a bunch of checks. At the same time we can now properly throw a 404 if the number of tag IDs doesn't match the number of tags found in the database matching these IDs. (we might want to rewrite the TagModel::getItem() method to use a single query instead of loading each tag separately with a Table call...)

Testing Instructions

Basically there should be no difference on an existing site between the current code and after applying this PR.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed