? PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
29 Oct 2022

Pull Request for #38353 (comment) .

Summary of Changes

Update to changes from following PRs:

  • #38353 - 3 files /media/com_menus/css/admin-item-edit_modules*.css*
  • #38823 - 6 files /media/com_templates/js/admin-template-compare*.js*
  • #38412 - 2 files /media/templates/*/*/scss/vendor/bootstrap/_bootstrap-rtl.scss for the 2 core templates

Remove wrong file /build/media_source/com_menus/css/admin-item-edit_modules.css added with PR #38353 .

Testing Instructions

Code review.

Or if you want to make a real test, update a current 4.2.4 or a 4.2.5-dev nightly build to the last 4.3 nightly build to get the actual result, and update a current 4.2.4 or a 4.2.5-dev nightly build to the update package built by Drone for this PR to get the expected result.

Actual result BEFORE applying this Pull Request

Files and folders mentioned in the description above are still present after updating from a current 4.2.4 or a 4.2.5-dev nightly build.

Expected result AFTER applying this Pull Request

All files and folders mentioned in the description above have been deleted after updating from a current 4.2.4 or a 4.2.5-dev nightly build.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar richard67 richard67 - open - 29 Oct 2022
avatar richard67 richard67 - change - 29 Oct 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Oct 2022
Category Administration com_admin
avatar richard67 richard67 - change - 29 Oct 2022
The description was changed
avatar richard67 richard67 - edited - 29 Oct 2022
avatar richard67 richard67 - change - 29 Oct 2022
The description was changed
avatar richard67 richard67 - edited - 29 Oct 2022
avatar brianteeman
brianteeman - comment - 29 Oct 2022

Good spot

avatar brianteeman
brianteeman - comment - 29 Oct 2022

I have tested this item successfully on 31cc2c1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39101.

avatar brianteeman brianteeman - test_item - 29 Oct 2022 - Tested successfully
avatar viocassel
viocassel - comment - 29 Oct 2022

I have tested this item successfully on 31cc2c1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39101.

avatar viocassel viocassel - test_item - 29 Oct 2022 - Tested successfully
avatar alikon alikon - change - 30 Oct 2022
Status Pending Ready to Commit
avatar alikon
alikon - comment - 30 Oct 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39101.

avatar wilsonge wilsonge - close - 30 Oct 2022
avatar wilsonge wilsonge - merge - 30 Oct 2022
avatar wilsonge wilsonge - change - 30 Oct 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-10-30 11:55:32
Closed_By wilsonge
Labels Added: ? PR-4.3-dev
avatar wilsonge
wilsonge - comment - 30 Oct 2022

Thanks!

Add a Comment

Login with GitHub to post a comment