Feeling Lucky
PR-4.3-dev
[#39063] - [4.3] Fixing php compatibility issues 5
- Closed
- 4 Apr 2023
- Medium
- Build: 4.3-dev
- # 39063
- Diff
- Hackwar:4.3-phpcompat-5
User tests: Successful: Unsuccessful:
Summary of Changes
This is one of several PRs to separate out the fixes from #38471. The track_errors feature was deprectaed in PHP 7.2 and removed in PHP 8.0. Most places where we use this, it isn't actually used.
Testing Instructions
Codereview
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
wilsonge
- comment
- 9 Mar 2023
It was also around ftp iirc (i know that's not an issue anymore but it was back when most the deprecations in 4 were being made).
| Labels |
Added:
PR-4.3-dev
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-04-04 07:49:50 |
| Closed_By | ⇒ | Hackwar |
shouldn't this class be deprecated? because we should use the framework class?
Even if it is, we should replace
$php_errormsgwith `error_get_last()ยด@wilsonge any idea why the filesystem classes are deprecated yet? I know that it's not the exactly the same, but the main b/c part is exceptions right?