Language Change PR-4.3-dev PR-5.0-dev ? Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
24 Oct 2022

Summary of Changes

This is one of several PRs to separate out the fixes from #38471. The mbstring.func_overload feature was deprectaed in PHP 7.2 and removed in PHP 8.0.

Testing Instructions

Codereview

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 24 Oct 2022
avatar Hackwar Hackwar - change - 24 Oct 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2022
Category Administration com_joomlaupdate Language & Strings Installation
avatar brianteeman
brianteeman - comment - 24 Oct 2022

as enforced by @HLeithner you cannot remove the language strings. you can only mark them as deprecated

avatar HLeithner
HLeithner - comment - 24 Oct 2022

based on the b/c policy, please deprecate and remove with 5.0 pr and add a documentation for this please

avatar Hackwar Hackwar - change - 24 Oct 2022
Labels Added: Language Change PR-4.3-dev
avatar Hackwar
Hackwar - comment - 24 Oct 2022

Done. here is the documentation PR: joomla/Manual#54

avatar HLeithner
HLeithner - comment - 25 Oct 2022

I think removing the check is wrong for valid PHP Versions (i.e. anything pre-php 8.0 - just because the string is deprecated doesn't mean people may have it set to undesirable values). I think we should just wrap it in a version check statement rather than remove it.

if it set in a php version that it doesn't support we don't need to care right? But in this case we support php 7.2 which also support mbstring.func_overload right? so I would rebase this pr on 5.0 problem solved.

avatar wilsonge
wilsonge - comment - 25 Oct 2022

That's fine too. But I think @Hackwar wanted to add the phpcs compat checking in now. And if it's removed in 8.0 a version check to not show unnecessary info is fine imo from a minor version

avatar HLeithner
HLeithner - comment - 25 Oct 2022

That's fine too. But I think @Hackwar wanted to add the phpcs compat checking in now. And if it's removed in 8.0 a version check to not show unnecessary info is fine imo from a minor version

in this case it makes more sense to wrap the code in a phpcs ignore block and add a deprecation notice

avatar HLeithner HLeithner - change - 7 Mar 2023
Labels Added: ?
avatar HLeithner HLeithner - change - 7 Mar 2023
Labels Added: PR-5.0-dev
avatar HLeithner HLeithner - change - 7 Mar 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-03-07 22:27:37
Closed_By HLeithner
avatar HLeithner HLeithner - close - 7 Mar 2023
avatar HLeithner HLeithner - merge - 7 Mar 2023
avatar HLeithner
HLeithner - comment - 7 Mar 2023

thanks

Add a Comment

Login with GitHub to post a comment