User tests: Successful: Unsuccessful:
This is one of several PRs to separate out the fixes from #38471. The mbstring.func_overload
feature was deprectaed in PHP 7.2 and removed in PHP 8.0.
Codereview
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_joomlaupdate Language & Strings Installation |
based on the b/c policy, please deprecate and remove with 5.0 pr and add a documentation for this please
Labels |
Added:
Language Change
PR-4.3-dev
|
Done. here is the documentation PR: joomla/Manual#54
I think removing the check is wrong for valid PHP Versions (i.e. anything pre-php 8.0 - just because the string is deprecated doesn't mean people may have it set to undesirable values). I think we should just wrap it in a version check statement rather than remove it.
if it set in a php version that it doesn't support we don't need to care right? But in this case we support php 7.2 which also support mbstring.func_overload right? so I would rebase this pr on 5.0 problem solved.
That's fine too. But I think @Hackwar wanted to add the phpcs compat checking in now. And if it's removed in 8.0 a version check to not show unnecessary info is fine imo from a minor version
in this case it makes more sense to wrap the code in a phpcs ignore block and add a deprecation notice
Labels |
Added:
?
|
Labels |
Added:
PR-5.0-dev
|
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-03-07 22:27:37 |
Closed_By | ⇒ | HLeithner |
thanks
as enforced by @HLeithner you cannot remove the language strings. you can only mark them as deprecated