[#39024] - [5.0] Replaces the dependency for model state with a State object
- Closed
- 23 Feb 2023
- Medium
- Build: 5.0-dev
- # 39024
- Diff
- Digital-Peak:cmsobject/state
User tests: Successful: Unsuccessful:
Summary of Changes
Replaces the state holder for model with an array based class. It removes the dependency for the deprecated CMSObject class.
Like that he performance can be improved by a third against using the CMSObject class.
Testing Instructions
- Create an article in the back end with the state published
- Filter for trashed articles
Actual result BEFORE applying this Pull Request
No article is shown.
Expected result AFTER applying this Pull Request
No article is shown.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org: joomla/Manual#78 and joomla/Manual#77
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Title |
|
||||||
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
PR-5.0-dev
|
||
Is there a reason not to use Registry? Given it has similar methods as JObject for b/c purposes but also implements arrayAccess as an interface which could be situationally useful
I tried to use registry but it doesn't support field access. So it would be a hard BC break. It is also massive slower than CMSObject or this new State class.
| Category | Libraries | ⇒ | Libraries Unit Tests |
| Labels |
Added:
?
|
||
Registry have some benefits also. In future you probably will be need serialisation, cloning.
Can try extend ModelState from Registry, and implement magick get/set.
Performance issue can overcome by disabling $separator, and make it always "flattened".
But that probably require changes in Registry class itself.
Much more work.
Hm, seems a simple State that you made here also fine :)
But then I would rather extend the registry class with the magic methods and not introduce a new class at all.
But then I would rather extend the registry class with the magic methods and not introduce a new class at all.
This would be against the argumentation in joomla-framework/registry#58
Closing in favor of #39663. When joomla-framework/registry#66 got merged, then we have the same speed without a new class which does more or less the same as the registry.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-02-23 13:00:56 |
| Closed_By | ⇒ | laoneo |
I have tested this item✅ successfully on a9aa13d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39024.