PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
22 Oct 2022

Summary of Changes

Split the CMSObject into traits so extension developers can already use them and remove their dependency from CMSObject. This pr is based on #38949 as it uses the exception trait.

The traits are deprecated so people will understand their code should be changes accordingly to the deprecate messages. In 5.0 the dependencies to CMSObject are removed from core then and do use the traits to ensure nothing will break in 4.

Testing Instructions

Load any back end view. CMSObject is used in tables and models so loading one of the views will use the CMSObject class.

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: joomla/Manual#50

  • No documentation changes for manual.joomla.org needed

avatar laoneo laoneo - open - 22 Oct 2022
avatar laoneo laoneo - change - 22 Oct 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Oct 2022
Category Libraries
avatar laoneo laoneo - change - 22 Oct 2022
The description was changed
avatar laoneo laoneo - edited - 22 Oct 2022
avatar laoneo
laoneo - comment - 22 Oct 2022

@wilsonge and @nikosdion feedback is appreciated

avatar laoneo laoneo - change - 22 Oct 2022
Labels Added: PR-4.3-dev
avatar Abernyte-Git
Abernyte-Git - comment - 22 Oct 2022

I have tested this item successfully on e993a85


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39020.

avatar Abernyte-Git Abernyte-Git - test_item - 22 Oct 2022 - Tested successfully
avatar nikosdion
nikosdion - comment - 25 Oct 2022

I am happy with this approach.

avatar obuisard obuisard - change - 9 Nov 2022
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-11-09 16:00:34
Closed_By obuisard
avatar obuisard obuisard - close - 9 Nov 2022
avatar obuisard obuisard - merge - 9 Nov 2022
avatar obuisard
obuisard - comment - 9 Nov 2022

Thank you Allon @laoneo for the PR

Add a Comment

Login with GitHub to post a comment