User tests: Successful: Unsuccessful:
Pull Request for Issue #10140 and #40996
-Create a banner, including some meta keywords.
-Create a banner module an setup the option "Search by Meta Keyword" to "YES".
-Activate the module in any position let's say "position-7" on Protostar template
-Disable the cache for the banners module and save.
-Create a Content article and setup some Meta Keywords which will be used to display the banner accordingly.
-Embed the module Banners inside the article using the "Module" button on the tinyMCE editor (the syntax will look something like this {loadmodule mod_banners,banners module title} ) and save it.
Edit: Can be tested with a normal banner module with 'Select by keywords' set to 'Yes'
Edit: Test with Client and No-Client set - both should work
-The Banners module embedded inside the article shows no content at all.
-The source code shows:
< div class = " module " >
< h3 > Banners module title< / h3 >
< div class = " banner group " > < / div >
< / div >
-The Banners module works good and shows the banner according to the Meta Keywords in the "position-7" or any other position in the default Protostar template.
-The banners module should also work the same way when embedded inside the article, displaying the banners according to the Meta Keywords.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Front End com_banners com_content Modules |
Labels |
Added:
?
|
Category | Front End com_banners com_content Modules | ⇒ | Front End com_banners com_content Libraries Modules |
I use an UserState variable to preserve to article.ids i need. This works, but is not very clean. I would rather like to enable $documents to use stateVariables, simply by including the 'StateBehaviorTrait' in the document class and then use $document->getState - what do you think?
Labels |
Added:
PR-4.3-dev
Removed: ? |
Labels |
Added:
bug
|
Title |
|
This pull request has been automatically rebased to 4.4-dev.
Title |
|
This pull request has been automatically rebased to 5.2-dev.
Title |
|
@MacJoom Could you fix the code style errors reported in the following log? https://ci.joomla.org/joomla/joomla-cms/58794/1/6 . Thanks in advance.