[#39016] - [5.4] Bugfix for Issue #10140 and #40996 - Banner Modules using 'Select by keywords' set to 'Yes'
- Pending
- Medium
- Build: 4.2-dev
- # 39016
- Diff
- MacJoom:bugfix-10140
User tests: Successful: Unsuccessful:
Pull Request for Issue #10140 and #40996
Summary of Changes
- Put keywords in a UserState variable com_content.articles.keywords
- Use UserState variable to get the keywords from the articles
Testing Instructions taken from #10140
-Create a banner, including some keywords (see publishing).
-Create a banner module an setup the option "Search by Meta Keyword" to "YES".
-Activate the module in any position let's say "banner" on Cassiopeia template
-Disable the cache for the banners module and save.
-Create a Content article and setup some keywords (see publishing) which will be used to display the banner accordingly.
- Test with Client set - seems to work only with client set
Actual result BEFORE applying this Pull Request
No banners shown
Expected result AFTER applying this Pull Request
Banners shown, acording to keywords
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_banners com_content Modules |
| Labels |
Added:
?
|
||
| Category | Front End com_banners com_content Modules | ⇒ | Front End com_banners com_content Libraries Modules |
I use an UserState variable to preserve to article.ids i need. This works, but is not very clean. I would rather like to enable $documents to use stateVariables, simply by including the 'StateBehaviorTrait' in the document class and then use $document->getState - what do you think?
| Labels |
Added:
PR-4.3-dev
Removed: ? |
||
| Labels |
Added:
bug
|
||
| Title |
|
||||||
This pull request has been automatically rebased to 4.4-dev.
| Title |
|
||||||
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
can you please fix the conflicts and decide if this is ready?
I have tested this item 🔴 unsuccessfully on 9936619
I have faced this issue when i click on apply patch but the patch could not be applied because it conflicts with a previously applied patch: components/com_banners/src/Model/BannersModel.php
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39016.
@chaitali-tekdi This branch has conflicts that must be resolved. So a test doesn't make sense at this time. You can find the information at the end of the github-page of the Pull Request:
Also notice that the PR is a draft.
This pull request has been automatically rebased to 5.3-dev.
| Title |
|
||||||
This pull request has been automatically rebased to 5.4-dev.
| Labels |
Added:
PR-5.3-dev
Removed: PR-4.3-dev |
||
| Title |
|
||||||
I've allowed myself to fix the conflicts. But system tests are failing, and I think it is related to this PR.
Running: site/modules/mod_banners/Default.cy.js (86 of 148)
Test in frontend that the banner module
1) can display banners
0 passing (388ms)
1 failing
1) Test in frontend that the banner module
can display banners:
CypressError: `cy.visit()` failed trying to load:
https://localhost/cmaria/
The response we received from your web server was:
> 500: Internal Server Error
This was considered a failure because the status code was not `2xx`.
| Labels |
Added:
PR-5.4-dev
Removed: PR-5.3-dev |
||
Years later i have a different approach to fix this... will work on it.
| Category | Front End com_banners com_content Modules Libraries | ⇒ | Front End com_banners com_content Modules |
Closing as we decided not to fix this issue and use tags for 7.0
Closing as we decided not to fix this issue and use tags in 7.0
Can you please re-open the closed issue then and make the appropriate deprecations in the code (at least for the language strings)
Also just to note that using tags would not really be an equivalent. Keywords are not visible on a site but tags would be.
@MacJoom Could you fix the code style errors reported in the following log? https://ci.joomla.org/joomla/joomla-cms/58794/1/6 . Thanks in advance.