bug PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar MacJoom
MacJoom
21 Oct 2022

Pull Request for Issue #10140 and #40996

Summary of Changes

  • Put article ids in a UserState variable
  • Use the article ids to get all the keywords from the articles
  • Avoid deprecation Warning in BannersModel

Testing Instructions taken from #10140

-Create a banner, including some meta keywords.
-Create a banner module an setup the option "Search by Meta Keyword" to "YES".
-Activate the module in any position let's say "position-7" on Protostar template
-Disable the cache for the banners module and save.

-Create a Content article and setup some Meta Keywords which will be used to display the banner accordingly.
-Embed the module Banners inside the article using the "Module" button on the tinyMCE editor (the syntax will look something like this {loadmodule mod_banners,banners module title} ) and save it.

Edit: Can be tested with a normal banner module with 'Select by keywords' set to 'Yes'

Edit: Test with Client and No-Client set - both should work

Actual result BEFORE applying this Pull Request

-The Banners module embedded inside the article shows no content at all.
-The source code shows:
< div class = " module " >
< h3 > Banners module title< / h3 >
< div class = " banner group " > < / div >
< / div >

Expected result AFTER applying this Pull Request

-The Banners module works good and shows the banner according to the Meta Keywords in the "position-7" or any other position in the default Protostar template.
-The banners module should also work the same way when embedded inside the article, displaying the banners according to the Meta Keywords.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar MacJoom MacJoom - open - 21 Oct 2022
avatar MacJoom MacJoom - change - 21 Oct 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Oct 2022
Category Front End com_banners com_content Modules
avatar MacJoom MacJoom - change - 21 Oct 2022
Labels Added: ?
avatar MacJoom MacJoom - change - 21 Oct 2022
The description was changed
avatar MacJoom MacJoom - edited - 21 Oct 2022
avatar joomla-cms-bot joomla-cms-bot - change - 21 Oct 2022
Category Front End com_banners com_content Modules Front End com_banners com_content Libraries Modules
avatar richard67
richard67 - comment - 21 Oct 2022

@MacJoom Could you fix the code style errors reported in the following log? https://ci.joomla.org/joomla/joomla-cms/58794/1/6 . Thanks in advance.

avatar MacJoom
MacJoom - comment - 28 Oct 2022

I use an UserState variable to preserve to article.ids i need. This works, but is not very clean. I would rather like to enable $documents to use stateVariables, simply by including the 'StateBehaviorTrait' in the document class and then use $document->getState - what do you think?

avatar MacJoom MacJoom - change - 24 Mar 2023
Labels Added: PR-4.3-dev
Removed: ?
avatar MacJoom MacJoom - change - 19 Jun 2023
Labels Added: bug
avatar MacJoom MacJoom - change - 22 Jun 2023
The description was changed
avatar MacJoom MacJoom - edited - 22 Jun 2023
avatar MacJoom MacJoom - change - 23 Jun 2023
Title
Bugfix for Issue #10140 - Banner Modules using 'Select by keywords' set to 'Yes'
Bugfix for Issue #10140 and #40996 - Banner Modules using 'Select by keywords' set to 'Yes'
avatar MacJoom MacJoom - edited - 23 Jun 2023
avatar HLeithner
HLeithner - comment - 30 Sep 2023

This pull request has been automatically rebased to 4.4-dev.

avatar HLeithner HLeithner - change - 24 Apr 2024
Title
Bugfix for Issue #10140 and #40996 - Banner Modules using 'Select by keywords' set to 'Yes'
[4.4] Bugfix for Issue #10140 and #40996 - Banner Modules using 'Select by keywords' set to 'Yes'
avatar HLeithner HLeithner - edited - 24 Apr 2024
avatar HLeithner
HLeithner - comment - 15 Nov 2024

This pull request has been automatically rebased to 5.2-dev.

avatar HLeithner HLeithner - change - 15 Nov 2024
Title
[4.4] Bugfix for Issue #10140 and #40996 - Banner Modules using 'Select by keywords' set to 'Yes'
[5.2] Bugfix for Issue #10140 and #40996 - Banner Modules using 'Select by keywords' set to 'Yes'
avatar HLeithner HLeithner - edited - 15 Nov 2024

Add a Comment

Login with GitHub to post a comment