[#39013] - [5.1] Load plugin group when executing batch tasks
- Fixed in Code Base
- 21 Oct 2023
- Medium
- Build: 4.3-dev
- # 39013
- Diff
- Hackwar:4.3-batch-events
User tests: Successful: Unsuccessful:
Summary of Changes
@grantg182 found an issue in J3 that batch operations aren't loading the content plugin group. He provided a quick fix in #38378, but since we don't do bugfixes in J3 anymore, this is unfortunately not acceptable anymore. However, this is still valid in J4 and thus this PR introduces loading these plugins in batch properly.
Testing Instructions
Add a die(); in the beginning of a content plugin. Batch move a few articles. See that it goes through. Apply patch. Move the articles again. See that you get a white screen because the content plugins are loaded.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
We had a discussion that with overriding and... I'll change it.
| Labels |
Added:
PR-4.3-dev
|
||
So now the content plugins will be triggered regardless if the method returns false, is that desirable behaviour?
This PR does not execute any plugins. It just loads the plugin group. The actual events are only executed in the single steps.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-04-18 12:06:31 |
| Closed_By | ⇒ | Hackwar | |
| Labels |
Added:
bug
?
|
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2023-04-18 12:06:31 | ⇒ | |
| Closed_By | Hackwar | ⇒ |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
| Labels |
Added:
PR-5.0-dev
Removed: PR-4.3-dev |
||
HLeithner
- | Title |
|
||||||
I have tested this item ✅ successfully on d0f01a6
Tested following the instructions, works as described.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39013.
| Labels |
Added:
Feature
PBF
Maintainers Checked
PR-5.1-dev
Removed: bug PR-5.0-dev |
||
I have tested this item ✅ successfully on 23247a9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39013.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39013.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-10-21 12:55:25 |
| Closed_By | ⇒ | LadySolveig | |
| Labels |
Added:
?
|
||
Thank you Hannes!
Is there a reason to drop this in each function rather than in the common initBatch function?