Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#39006] - [4.3] Migrate the extension finder plugin to services

? PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
21 Oct 2022

Summary of Changes

Migrate the extension finder plugin to services.

Testing Instructions

Install an extension.

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar laoneo laoneo - open - 21 Oct 2022
avatar laoneo laoneo - change - 21 Oct 2022
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Oct 2022
Category ⇒ Front End Plugins
avatar laoneo laoneo - change - 21 Oct 2022
Labels Added: PR-4.3-dev
6cd51e1 21 Oct 2022 avatar laoneo cs
avatar Abernyte-Git
Abernyte-Git - comment - 22 Oct 2022

I have tested this item ✅ successfully on e46b1ec

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39006.

avatar Abernyte-Git Abernyte-Git - test_item - 22 Oct 2022 - Tested successfully
avatar laoneo
laoneo - comment - 9 Nov 2022

@heelc29 do you also have time to test this?

avatar heelc29
heelc29 - comment - 9 Nov 2022

Can you remove the two require -> file is empty

joomla-cms/plugins/extension/finder/src/Extension/Finder.php

Line 162 in 8208f27

require_once JPATH_ADMINISTRATOR . '/components/com_finder/helpers/indexer/helper.php';

joomla-cms/plugins/extension/finder/src/Extension/Finder.php

Line 196 in 8208f27

require_once JPATH_ADMINISTRATOR . '/components/com_finder/helpers/indexer/helper.php';

joomla-cms/administrator/components/com_finder/helpers/indexer/helper.php

Lines 13 to 18 in 17ac356

/**
* Finder Indexer Helper class.
*
* @since 2.5
* @deprecated 5.0 Use \Joomla\Component\Finder\Administrator\Indexer\Helper instead
*/

Import is used

joomla-cms/plugins/extension/finder/src/Extension/Finder.php

Line 16 in 8208f27

use Joomla\Component\Finder\Administrator\Indexer\Helper;

avatar laoneo
laoneo - comment - 10 Nov 2022

Thanks for the hint @heelc29, removed it.

avatar heelc29
heelc29 - comment - 10 Nov 2022

I have tested this item ✅ successfully on 1b619e9

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39006.

avatar heelc29 heelc29 - test_item - 10 Nov 2022 - Tested successfully
avatar laoneo laoneo - change - 10 Nov 2022
Status Pending ⇒ Ready to Commit
avatar laoneo
laoneo - comment - 10 Nov 2022

Setting RTC as only requires are removed which are pointing to an empty file.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39006.

avatar obuisard obuisard - change - 10 Nov 2022
Labels Added: ?
avatar obuisard obuisard - change - 10 Nov 2022
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2022-11-10 20:02:50
Closed_By ⇒ obuisard
avatar obuisard obuisard - close - 10 Nov 2022
avatar obuisard obuisard - merge - 10 Nov 2022
avatar obuisard
obuisard - comment - 10 Nov 2022

Thank you Allon @laoneo!

Add a Comment

Login with GitHub to post a comment