Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#39003] - Deprecation message in PHP 8.1, clearer code

? PHP 8.x ? Pending

User tests: Successful: Unsuccessful:

avatar MacJoom
MacJoom
20 Oct 2022

Summary of Changes

  • Avoid deprecation message in PHP 8.1
  • clearer code

Testing Instructions

Setup a custom module
Setup an article with a {loadmodule costum}

Turn on all PHP Warnings
display_errors = On
error_reporting = E_ALL | E_STRICT

Actual result BEFORE applying this Pull Request

Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/clients/client2/web14/web/joomla-cms/plugins/content/loadmodule/loadmodule.php on line 115

Expected result AFTER applying this Pull Request

No warning anymore

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar MacJoom MacJoom - open - 20 Oct 2022
avatar MacJoom MacJoom - change - 20 Oct 2022
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Oct 2022
Category ⇒ Front End Plugins
avatar MacJoom MacJoom - change - 20 Oct 2022
Labels Added: ?
avatar MacJoom MacJoom - change - 21 Oct 2022
Labels Added: PHP 8.x
avatar alikon
alikon - comment - 21 Oct 2022

I have tested this item ✅ successfully on 992ef05

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39003.

avatar alikon alikon - test_item - 21 Oct 2022 - Tested successfully
avatar viocassel
viocassel - comment - 21 Oct 2022

I have tested this item ✅ successfully on 992ef05

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39003.

avatar viocassel viocassel - test_item - 21 Oct 2022 - Tested successfully
avatar richard67 richard67 - change - 21 Oct 2022
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 21 Oct 2022

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39003.

avatar rdeutz rdeutz - change - 22 Oct 2022
Labels Added: ?
avatar bembelimen bembelimen - change - 23 Oct 2022
Status Ready to Commit ⇒ Pending
avatar bembelimen
bembelimen - comment - 23 Oct 2022

Remove RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39003.

avatar MacJoom MacJoom - change - 23 Oct 2022
Labels Removed: ?
avatar laoneo
laoneo - comment - 12 Jan 2023

@HLeithner can you approve when the code is ok, then people can test it again?

avatar carlitorweb carlitorweb - test_item - 12 Jan 2023 - Tested successfully
avatar carlitorweb
carlitorweb - comment - 12 Jan 2023

I have tested this item ✅ successfully on 6b93585

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39003.

avatar Quy Quy - test_item - 23 Jan 2023 - Tested successfully
avatar Quy
Quy - comment - 23 Jan 2023

I have tested this item ✅ successfully on 935c0ec

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39003.

avatar Quy Quy - alter_testresult - 23 Jan 2023 - carlitorweb: Tested successfully
avatar Quy Quy - change - 23 Jan 2023
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 23 Jan 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39003.

avatar MacJoom MacJoom - change - 28 Jan 2023
Labels Added: ?
avatar fancyFranci fancyFranci - change - 3 Feb 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-02-03 21:49:46
Closed_By ⇒ fancyFranci
avatar fancyFranci fancyFranci - close - 3 Feb 2023
avatar fancyFranci fancyFranci - merge - 3 Feb 2023
avatar fancyFranci
fancyFranci - comment - 3 Feb 2023

Looks good. Thank you!

Add a Comment

Login with GitHub to post a comment