Feeling Lucky
PR-4.3-dev
[#39000] - [4.3] Phan: Using DatabaseInterface::quoteName instead of QueryInterface::quoteName
- Fixed in Code Base
- 21 Oct 2022
- Medium
- Build: 4.3-dev
- # 39000
- Diff
- Hackwar:4.3-phan-improvements-1
User tests: Successful: Unsuccessful:
Summary of Changes
This is one PR of several to fix issues from a scan of the static codeanalyser phan. There are a few cases where we are using the quoteName function in our query object. Unfortunately our QueryInterface interface does not contain this method. In order to keep the code consistent, this PR changes these cases to use the quoteName method from the database object directly.
Testing Instructions
This can only be tested by code review.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields com_finder |
| Labels |
Added:
PR-4.3-dev
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-10-21 12:01:17 |
| Closed_By | ⇒ | laoneo |
laoneo
- comment
- 21 Oct 2022
Thanks!
code reviews, looks good to me