Pull Request for Issue #38599 .
finder aka smart search index contains macros of loadmodule in search results

Summary of Changes

in onContentPrepare of loadmodule:
while indexing remove macros (loadposition, loadmoduleid, loadmodule) from article text with preg_replace

Testing Instructions (from #38599)

Enable smart search aka finder and publish a finder search module somewhere or connect a menu item to the smart search item type.
Enable the load modules plugin.
Enable the smart search content plugin.
Create a site module of type custom with some content and place it at custom positon herewego.
Create an article and place a loadposition macro in that article like this:
{loadposition herewego}

Now the finder automatically indexes the new article.
Go to the search box and search for loadposition or herewego.

Within the Smart Search component you can clear the index under maintenace and reindex with the index button
Do a clear before applying the PR.

Actual result BEFORE applying this Pull Request

I would not expect to see search results containing the article with the loadposition macro.

e.g. {loadposition herewego} in the search results

I would not expect the search suggestions list containing the search items loadposition and herewego.
Instead I would expect that the macro is deleted in this case before indexing.

Expected result AFTER applying this Pull Request

The search result does contain the article where the loadposition macro is placed and the suggestion list does not contain both loadposition and herewego.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed