I've run the static code analyser phan over most of our current 4.3 codebase. The result are roughly 6000 reported issues, even though most of them are duplicates of for example the toolbar buttons. I'm attaching a file with those results here so that people can have a look at this and maybe fix some of them.
phan2.txt
Labels |
Added:
No Code Attached Yet
|
Labels |
Added:
?
|
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-09-25 16:52:03 |
Closed_By | ⇒ | Hackwar | |
Labels |
Added:
Feature
Removed: ? |
In the last 2 years a lot of improvements have been made in this regard and this issue is not current anymore. To answer the questions of @nikosdion:
Yes, we can create PRs which only add PHPdoc comments. You don't have to tag anyone, they are normal PRs and will be handled by the maintainers among others. I've created several PRs to fix this stuff and it might need some time, but the stuff gets done eventually.
I don't know about the properties in the table objects. Lets see what 5.3/6.0 will bring.
Issues in the platform should be fixed in the platform and normally will be updated in the CMS with the next minor release. In some cases it might even be updated in a patch version.
A lot of the static code analysis results are misfires because (among other things):
@property
PHPdoc annotations. This is something we should REALLY fix to get rid of CMSObject usage in there a.s.a.p., see the PRs on the subject by me and George.There are many variations of the same all over the place.
Most of these issues can be solved with type-hinting comments, some of them by introducing concrete properties. Some issues are core CMS, some issues are Platform.
Here are my questions:
@property
declarations? Both methods are valid, both work now and with the proposed PRs for removing CMSObjectThank you in advance.