[#38989] - Fix error
- Fixed in Code Base
- 23 Oct 2022
- Medium
- Build: 4.2-dev
- # 38989
- Diff
- RickR2H:codemirror-error
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
PR #38863 introduces a bug if Codemirror is selected as default editor.
Testing Instructions
Set the default editor to Codemirror
Actual result BEFORE applying this Pull Request
When an article is edited, there is an error when Codemirror is set ad default editor.
Warning: Undefined property: stdClass::$readOnly in C:\wamp64\www\joomlacms\plugins\editors\codemirror\layouts\editors\codemirror\element.php on line 41
Expected result AFTER applying this Pull Request
The error is the article editor is gone and the changes made in #38863 still work.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
?
|
||
Doesn’t isset also cover the check for not null so the check for not null can be removed?
You are right. isset will return true if variable is set and not NULL.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38989.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38989.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38989.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-10-23 07:42:53 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
Doesn’t isset also cover the check for not null so the check for not null can be removed?