? Success

User tests: Successful: Unsuccessful:

avatar Achal-Aggarwal
Achal-Aggarwal
13 Jul 2014
avatar Achal-Aggarwal Achal-Aggarwal - open - 13 Jul 2014
avatar wilsonge
wilsonge - comment - 13 Jul 2014

Looks perfect to me! Nice one. Have we fixed this in framework as well?

avatar Bakual
Bakual - comment - 14 Jul 2014

Is there a way to test this?

avatar Achal-Aggarwal
Achal-Aggarwal - comment - 14 Jul 2014

@wilsonge No, I haven't started database package yet. I skipped it and took language and image first.

@Bakual All tests should pass on PHP 5.5. Check discussion on PR 3673. This PR just fix some failing tests.

avatar mbabker
mbabker - comment - 14 Jul 2014

@Bakual - In the CMS, there isn't a way to test the database piece as it's a change directly to the SQLite driver which is only used with the unit tests right now.

avatar Bakual Bakual - change - 14 Jul 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-07-14 12:52:29
avatar Bakual Bakual - close - 14 Jul 2014
avatar Bakual Bakual - close - 14 Jul 2014
avatar Bakual
Bakual - comment - 14 Jul 2014

Merged since Travis is fine and Code also looks fine.

Add a Comment

Login with GitHub to post a comment