[#38977] - Content plugins don't check the object they are operating on
- Fixed in Code Base
- 13 Nov 2022
- Medium
- Build: 4.2-dev
- # 38977
- Diff
- nikosdion:patch-1
User tests: Successful: Unsuccessful:
Pull Request for Issue #38976 .
Summary of Changes
The email cloak, fields and load module content plugins now check if the content has a text property before trying to process it, thereby avoiding the previously thrown PHP deprecated notices.
Testing Instructions
- Install a Joomla 4.2 site
- Install the following package: pkg_example-0.0.0-dev202210171411-rev865c625.zip
- Go to Components, Example Component
Actual result BEFORE applying this Pull Request
There are deprecated notices displayed under the “onContentPrepare — as object without a text property” and “onContentPrepare — as object without a text property, with a magic __get” headers.
Expected result AFTER applying this Pull Request
No deprecated notices are displayed.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
?
|
||
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38977.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38977.
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-11-13 09:52:35 |
| Closed_By | ⇒ | rdeutz |
I have tested this item✅ successfully on 36996de
Tested successfully in Joomla 4.2.4-dev of 24 October in Wampserver using PHP 8.1.10
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38977.