User tests: Successful: Unsuccessful:
Pull Request for Issue #38961 .
Get featured up & down info
edit a featured article from frontend
featured up & down data cleaned
no more data loss
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Front End com_content |
Labels |
Added:
?
|
as usual
for more info https://docs.joomla.org/Testing_Joomla!_patches/en
I have tested this item
I have tested the patch on a copy of a live site.
The result of the test was good.
Without a patch there was no field information for the beginning and end of the featured articles.
It works fine with the patch.
Even after saving in the frontend, the data is the same on the frontend and backend.
Is it possible to see this solutuion in the next Joomla 4 release?
For example in 4.2.5?
I think you can improve the current code a a little by doing the same with the code in Article
model https://github.com/joomla/joomla-cms/blob/4.2-dev/administrator/components/com_content/src/Model/ArticleModel.php#L402-L430
if ($itemId)
block($value->featured)
, same with https://github.com/joomla/joomla-cms/blob/4.2-dev/administrator/components/com_content/src/Model/ArticleModel.php#L409What happened to this PR? Why did it not appear in 4.2.6? More testing on the front and backend shows that:
as usual it needs 2 successfull tests and then it's up mantainers / Release leaders to decide
I have tested this item
The PR solves the issue. Further improvement could be made to avoid repeating same code for both frontend and backend, but it could be done in separate PR.
@Scrabble96 or @WoodyF4u If you have time, please test this PR so that we can get the issue fixed for next release.
I have tested the patch successfully using the Joomla! Patch Tester component on a development site online. I can't see a way to submit my test results, though.
You can go to https://issues.joomla.org/tracker/joomla-cms/38975 , click on Test this button at the top to report test result. See the attached screenshot for more details
I have tested this item
Tested as per my comment 2022/12/29
Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks!
I just tested it successfully as well.
I saw that two successful tests have already been done.
So I can't officially confirm it anymore, but I agree with this patch.
I just tested it successfully as well.
I saw that two successful tests have already been done.
So I can't officially confirm it anymore, but I agree with this patch.
@WoodyF4u you can still record your successful test
I have tested this item
My test was succesfull.
Hi Brian,
Done.
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-01-06 21:24:45 |
Closed_By | ⇒ | fancyFranci |
Thanks a lot!
I was the person who started #38961
I have seen that it is closed.
We are asked to test it in this PR.
But is there something to test anywhere? Where can I find it?