? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
17 Oct 2022

Pull Request for Issue #38961 .

Summary of Changes

Get featured up & down info

Testing Instructions

edit a featured article from frontend

Actual result BEFORE applying this Pull Request

featured up & down data cleaned

Expected result AFTER applying this Pull Request

no more data loss

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar alikon alikon - open - 17 Oct 2022
avatar alikon alikon - change - 17 Oct 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Oct 2022
Category Front End com_content
avatar WoodyF4u
WoodyF4u - comment - 17 Oct 2022

I was the person who started #38961
I have seen that it is closed.
We are asked to test it in this PR.
But is there something to test anywhere? Where can I find it?

avatar alikon alikon - change - 18 Oct 2022
Labels Added: ?
avatar alikon
alikon - comment - 19 Oct 2022
avatar WoodyF4u
WoodyF4u - comment - 22 Oct 2022

I have tested this item successfully on b77c583

I have tested the patch on a copy of a live site.
The result of the test was good.
Without a patch there was no field information for the beginning and end of the featured articles.
It works fine with the patch.
Even after saving in the frontend, the data is the same on the frontend and backend.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38975.

avatar WoodyF4u WoodyF4u - test_item - 22 Oct 2022 - Tested successfully
avatar WoodyF4u
WoodyF4u - comment - 29 Oct 2022

Is it possible to see this solutuion in the next Joomla 4 release?
For example in 4.2.5?

avatar joomdonation
joomdonation - comment - 29 Nov 2022

I think you can improve the current code a a little by doing the same with the code in Article model https://github.com/joomla/joomla-cms/blob/4.2-dev/administrator/components/com_content/src/Model/ArticleModel.php#L402-L430

avatar Scrabble96
Scrabble96 - comment - 14 Dec 2022

What happened to this PR? Why did it not appear in 4.2.6? More testing on the front and backend shows that:

  1. On front end - i) add start and finish dates for Featured, ii) 'Save' (the dates apparently disappear) then 'Cancel', or add the dates and then 'Save and Close', iii) check in backend: Featured dates are shown;
    However...
  2. On front end - i) add start and finish dates for Featuring, ii) 'Save' (the dates apparently disappear), iii) continue editing content, iv) Click 'Save and Close', v) check in backend: Featured dates are lost because they have been cleared earlier in the 'Save' operation.
avatar alikon
alikon - comment - 14 Dec 2022

as usual it needs 2 successfull tests and then it's up mantainers / Release leaders to decide

avatar joomdonation joomdonation - test_item - 29 Dec 2022 - Tested successfully
avatar joomdonation
joomdonation - comment - 29 Dec 2022

I have tested this item successfully on d04129d

The PR solves the issue. Further improvement could be made to avoid repeating same code for both frontend and backend, but it could be done in separate PR.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38975.

avatar joomdonation
joomdonation - comment - 29 Dec 2022

@Scrabble96 or @WoodyF4u If you have time, please test this PR so that we can get the issue fixed for next release.

avatar Scrabble96
Scrabble96 - comment - 29 Dec 2022

I have tested the patch successfully using the Joomla! Patch Tester component on a development site online. I can't see a way to submit my test results, though.

avatar joomdonation
joomdonation - comment - 29 Dec 2022

You can go to https://issues.joomla.org/tracker/joomla-cms/38975 , click on Test this button at the top to report test result. See the attached screenshot for more details
test

avatar Scrabble96 Scrabble96 - test_item - 29 Dec 2022 - Tested successfully
avatar Scrabble96
Scrabble96 - comment - 29 Dec 2022

I have tested this item successfully on d04129d

Tested as per my comment 2022/12/29


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38975.

avatar joomdonation joomdonation - change - 29 Dec 2022
Status Pending Ready to Commit
avatar joomdonation
joomdonation - comment - 29 Dec 2022

RTC. Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38975.

avatar WoodyF4u
WoodyF4u - comment - 3 Jan 2023

I just tested it successfully as well.
I saw that two successful tests have already been done.
So I can't officially confirm it anymore, but I agree with this patch.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38975.

avatar WoodyF4u
WoodyF4u - comment - 3 Jan 2023

I just tested it successfully as well.
I saw that two successful tests have already been done.
So I can't officially confirm it anymore, but I agree with this patch.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38975.

avatar brianteeman
brianteeman - comment - 3 Jan 2023

@WoodyF4u you can still record your successful test


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38975.

avatar WoodyF4u WoodyF4u - test_item - 3 Jan 2023 - Tested successfully
avatar WoodyF4u
WoodyF4u - comment - 3 Jan 2023

I have tested this item successfully on d04129d

My test was succesfull.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38975.

avatar WoodyF4u
WoodyF4u - comment - 3 Jan 2023

Hi Brian,
Done.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38975.

avatar fancyFranci fancyFranci - change - 6 Jan 2023
Labels Added: ?
avatar fancyFranci fancyFranci - change - 6 Jan 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-01-06 21:24:45
Closed_By fancyFranci
avatar fancyFranci fancyFranci - close - 6 Jan 2023
avatar fancyFranci fancyFranci - merge - 6 Jan 2023
avatar fancyFranci
fancyFranci - comment - 6 Jan 2023

Thanks a lot!

Add a Comment

Login with GitHub to post a comment