? Pending

User tests: Successful: Unsuccessful:

avatar n3t
n3t
16 Oct 2022

$fieldCache had invalid type of FieldsModel, should be FieldModel

Summary of Changes

Added use and corrected var type

Testing Instructions

Open FieldsHelper in yor favourite IDE (PHPStorm in my case)

Actual result BEFORE applying this Pull Request

self::$fieldCache->getFieldValues (line 171) will show warning "Cannot find declaration of getFieldValues"

Expected result AFTER applying this Pull Request

Declaration is found, you can click to go to it.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar n3t n3t - open - 16 Oct 2022
avatar n3t n3t - change - 16 Oct 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Oct 2022
Category Administration com_fields
avatar wilsonge wilsonge - change - 17 Oct 2022
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-10-17 09:47:11
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 17 Oct 2022
avatar wilsonge wilsonge - merge - 17 Oct 2022
avatar wilsonge
wilsonge - comment - 17 Oct 2022

Clearly correct change and just a doc string so merging on review

Add a Comment

Login with GitHub to post a comment