[#38964] - Added class `previous` to the 'Previous' button.
- Fixed in Code Base
- 18 Oct 2022
- Medium
- Build: 4.2-dev
- # 38964
- Diff
- nasirkhan:patch-1
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Added class previous to the 'Previous' button. Right now there is no additional class available for the 'Previous' button.
Testing Instructions
There will be a new class in the 'Previous' button.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
One new class was added to the button. Functionally and visually there will be no changes. By using this new class, it will be be easier to write button specific styles easily.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
I think this should be rebased to 4.3-dev because it’s a new feature or improvement and not a bug fix. So it should go into 4.3.
Thanks @richard67. I updated the base branch to 4.3-dev.
The Labels needed to be updated by someone.
it is a bug. we have a next class so there should have been a previous class
it is a bug. we have a next class so there should have been a previous class
@nasirkhan Sorry, I was not aware of that. Could you change back to 4.2-dev?
moved back to 4.2-dev
I have tested this item
I can confirm the issue that the "Next" button has a "next" class, but the "Previous" button has no "previous" class, and that this PR fixes this issue by adding the missing class to the "Previous" button, and finally that this doesn't have a visual impact.
I've tested with the "Your Modules" article from Blog sample data and the standard Cassiopeia template.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38964.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38964.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38964.
Quy
- | Labels |
Added:
?
?
|
||
Thankyou for your first contribution!
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-10-18 13:30:07 |
| Closed_By | ⇒ | wilsonge |
I think this should be rebased to 4.3-dev because it’s a new feature or improvement and not a bug fix. So it should go into 4.3.