[#38939] - [4.4] PHP8.2 Add missing class properties to views
- Fixed in Code Base
- 29 Apr 2023
- Medium
- Build: 4.3-dev
- # 38939
- Diff
- wilsonge:fix/missing-class-propertties
User tests: Successful: Unsuccessful:
Summary of Changes
In several view classes we are missing defining properties of the class that we then use later on in the view causing us to have magic properties. This ensures that they are correctly set in the code base as explicit properties
Testing Instructions
Check tag list, categories, articles list and newsfeed list views and check that they continue to work as before with no changes
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_categories com_content com_newsfeeds com_tags |
| Labels |
Added:
PR-4.3-dev
|
||
| Title |
|
||||||
| Labels |
Added:
PHP 8.x
|
||
| Title |
|
||||||
I have tested this item
Also code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38939.
| Labels |
Added:
?
bug
|
||
| Title |
|
||||||
| Labels |
Added:
PR-4.4-dev
Removed: PR-4.3-dev |
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38939.
| Labels |
Removed:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-04-29 11:28:11 |
| Closed_By | ⇒ | laoneo |
Thanks!
I have tested this item✅ successfully on f818f17
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38939.