Feeling Lucky
No Code Attached Yet
[#38927] - [4.2.3] PHP 8.1. Progressive caching. Automatic conversion of false to array is deprecated
- Closed
- 12 Oct 2022
- Medium
- Build: 4.2-dev
- # 38927
Steps to reproduce the issue
While debugging, I stumbled across this known bug and disabled caching for the affected mod_articles_categories, which was followed by a deprecated message that can be reproduced as follows.
- Joomla 4.2.3
- PHP 8.1
- Joomla configuration: Activate progressive caching (see image below).
- !!Clear Joomla Cache!!
- Frontend: Open a page with modules where caching is not disabled (don't know if that matters).
- With hardly configured n3t debug plugin I get
Deprecated: Automatic conversion of false to array is deprecated
File: libraries/src/Document/HtmlDocument.php:561
See also images.
joomla-cms-bot
- | Labels |
Added:
No Code Attached Yet
|
||
| Title |
|
||||||
Fedik
- comment
- 12 Oct 2022
Yeap, and I would initialise it on get()
Kind of:
$cbuffer = $cache->get('cbuffer_' . $type) ?: [];| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-10-12 12:36:28 |
| Closed_By | ⇒ | Fedik |
$cbuffercan only be boolean false if the call to$cache->getin line 545 returns false, which is the case when caching is switched off, but then we should not be in that branch of the if statement.A bit below that line, in line 548 the method returns when
$cbuffer[$hash]is set.So it seems that after that line we can assume that the
$cbufferwas not properly set.If my assumption is true, it is maybe sufficient and correct just to add a line
$cbuffer = [];(or$cbuffer = array();if keeping the old array syntax like elsewhere in that file) before line 561.@Fedik What do you think? Can it be solved like this?